-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add list of recent DM conversations #119
Comments
This feature has two parts: the data, and the UI. The data comes from For a full implementation, we'll need to keep the data up to date using server events, in particular For the UI, let's give this list its own screen, and navigate to the screen with a new button added to |
Chat thread asking @terpimost for input on the design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594568 As a baseline, for 1:1 conversations we can make the list items look like the design in zulip/zulip-mobile#5512 . For group conversations, a usable baseline would be:
Those baseline designs are for getting something usable at alpha level without much work; if there's a design aspect in them that's complicated to implement, we should leave that as a TODO and save the polish effort for after further discussion, when we have a design we're more confident we'll want to stick with. If we do this issue before tracking users' presence (#196) or status (#197), we can leave those out of the scope of this issue. In that case, we'll add them to this UI as part of the issue for adding the data, #196 or #197 respectively. |
Toward zulip#119, the list of recent DM conversations. Inspired by how we do this in zulip-mobile, including in the tests.
Toward zulip#119, the list of recent DM conversations. Much of this code was transcribed from zulip-mobile; in particular, from: src/pm-conversations/pmConversationsModel.js src/pm-conversations/__tests__/pmConversationsModel-test.js
Toward zulip#119, the list of recent DM conversations. Much of this code was transcribed from zulip-mobile; in particular, from: src/pm-conversations/pmConversationsModel.js src/pm-conversations/__tests__/pmConversationsModel-test.js
Toward zulip#119, the list of recent DM conversations. Much of this code was transcribed from zulip-mobile; in particular, from: src/pm-conversations/pmConversationsModel.js src/pm-conversations/__tests__/pmConversationsModel-test.js
Copying @terpimost's reply there: |
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
…ting This way, the Route object itself is distinguishable from other Route objects. This will come in handy in widget tests for the upcoming recent-DMs screen (zulip#119), where we'll want to assert that tapping on a conversation brings up the appropriate message list. While we're at it, add the usual `extension FooChecks on Subject<Foo>` boilerplate that we'll use in those tests.
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
…ting This way, the Route object itself is distinguishable from other Route objects. This will come in handy in widget tests for the upcoming recent-DMs screen (zulip#119), where we'll want to assert that tapping on a conversation brings up the appropriate message list. While we're at it, add the usual `extension FooChecks on Subject<Foo>` boilerplate that we'll use in those tests.
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
…ting This way, the Route object itself is distinguishable from other Route objects. This will come in handy in widget tests for the upcoming recent-DMs screen (zulip#119), where we'll want to assert that tapping on a conversation brings up the appropriate message list. While we're at it, add the usual `extension FooChecks on Subject<Foo>` boilerplate that we'll use in those tests.
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
The screen's content area (so, the list of conversations, but not the app bar at the top) is built against Vlad's design: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594654 except that some features that appear in that design are left unimplemented for now, since we don't have data structures for them yet: - unread counts - user presence Fixes: zulip#119
Made by Vlad for mobile. This is the SVG file Vlad shared on CZO: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20DM-conversation.20list/near/1594671 Related: zulip#119
…ting This way, the Route object itself is distinguishable from other Route objects. This will come in handy in widget tests for the upcoming recent-DMs screen (zulip#119), where we'll want to assert that tapping on a conversation brings up the appropriate message list. While we're at it, add the usual `extension FooChecks on Subject<Foo>` boilerplate that we'll use in those tests.
Like
PmConversationsScreen
inzulip-mobile
.The text was updated successfully, but these errors were encountered: