Be consistent in aligning channel icon with channel name

[chrisbobbe]

PR #1877 will add a function channelTopicLabelSpan as a canonical way to produce a span of text with a channel icon plus name, and optionally a topic. E.g.:

That PR only uses it in the channel and topic action sheet headers. But there are other places that make good candidates for using it:

• Channel rows in the Inbox, Channels, and All channels pages
• The channel name in a message-list app bar
• Recipient headers in the message list

Related issues:

• RTL: Flip directional icons, like chevron_right and send, in RTL mode #1907
• RTL bug in channel-and-topic label span #1908

[manthansubhash01]

Hi @chrisbobbe
I’ve gone through PR #1877 and the new channelTopicLabelSpan function. I understand that the goal is to replace the older, duplicated channel/topic label implementations across the app with this new canonical version.
Could you please assign this issue to me?
I have already set up the development environment and I’m ready to start working on it.

[chrisbobbe]

Sure! A key requirement for a PR will be clear before-and-after screenshots. For each place you change the implementation, please post a pair of screenshots, "Before" and "After", that are identical except for the single change you're making. This is especially important when the changes are subtle and would be easy to miss. For an example, see #1998. Flutter's hot reload feature will be useful for this.

[manthansubhash01]

Hello @chrisbobbe I was testing my changes everything works correctly in both light and dark mode. I am following the docs but when I run flutter test most of the tests failed even in files I didn’t modify, currently I don't know how to proceed, can you please help me out. Should I fix all of these failing tests ? or proceed with the PR.

[chrisbobbe]

Could you join us in the #mobile-dev-help channel in the Zulip development community and copy-paste some examples of failing tests? You can send a draft PR, too, so we can see the code.

[manthansubhash01]

ok got it, thank you.

[manthansubhash01]

Hello,
Sorry for the delayed reply I've got help and resolve the test failures. So sorry if I wasted your time. Can I open a PR.

[manthansubhash01]

@chrisbobbe
Hello and so sorry to ask you but I have raised the PR could you please review it I'm happy to make any changes.