Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep through UI strings to internationalize #277

Open
gnprice opened this issue Aug 17, 2023 · 1 comment
Open

Sweep through UI strings to internationalize #277

gnprice opened this issue Aug 17, 2023 · 1 comment
Assignees
Labels
a-i18n Translation, localization, internationalization
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Aug 17, 2023

This is a followup to #275. After we have that basic framework for using translated strings in the UI, we'll want to sweep through our existing code and convert it all to use that framework.

Initially this won't do much of anything from a user's perspective, because we won't have more than a handful of strings translated until we wire things up to a service where people can contribute such translations, #276.

Nevertheless it's useful to do this early, because it sets the pattern so that we naturally follow it in new code, rather than having more code that needs to change in an eventual sweep later. We may also come across places that need a context object and didn't before, or otherwise call for refactoring, and it's convenient to do that sooner so that other changes to the same code are based on the new structure from the beginning.

Other notes:

  • Many of these spots are marked with TODO(i18n), though many others are not.
  • Some spots marked TODO(i18n) are for different needs like formatting dates and times. Those are out of scope of this issue.
  • If some strings are especially difficult to wire up for translation for some reason, we can mark them with TODO(i18n) and also file followup issues, and then leave them out for this issue.
@gnprice gnprice added the a-i18n Translation, localization, internationalization label Aug 17, 2023
@gnprice gnprice added this to the Alpha milestone Aug 17, 2023
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Sep 20, 2023
@gnprice gnprice self-assigned this Oct 9, 2023
@gnprice gnprice modified the milestones: Alpha, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@Detective-Khalifah

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-i18n Translation, localization, internationalization
Projects
Status: No status
Development

No branches or pull requests

4 participants