Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notifications on iOS #321

Closed
gnprice opened this issue Oct 16, 2023 · 0 comments · Fixed by #409
Closed

Show notifications on iOS #321

gnprice opened this issue Oct 16, 2023 · 0 comments · Fixed by #409
Assignees
@gnprice
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications
Milestone
M0: Alpha

Comments

@gnprice
Copy link
Member

gnprice commented Oct 16, 2023

Part of #122; companion to #320.

I have a draft branch for #320 which I plan to send soon, which won't yet include iOS support, in order to start getting things merged and reduce the complexity of what's outstanding. But iOS support will be next, and still an alpha task.
@gnprice gnprice added a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications labels Oct 16, 2023
@gnprice gnprice added this to the Alpha milestone Oct 16, 2023
@gnprice gnprice self-assigned this Oct 16, 2023
@gnprice gnprice mentioned this issue Oct 27, 2023
Merged
gnprice added a commit that referenced this issue Oct 31, 2023
@gnprice
notif: Show notifications! on Android, in foreground
b6badf5 
This implements most of the remaining work of #320.

It doesn't yet deliver most of the user-facing value: for that, the
remaining piece will be to make notifications appear when the app is
in the background as well as when it's in the foreground.  I have a
draft for that and it works, but the tests require some more fiddling
which I may not get to today, so I wanted to get the bulk of this
posted for review.

Many other improvements still to be made are tracked as their own
issues: most notably iOS support #321, and opening a conversation
by tapping the notification #123.
@gnprice gnprice mentioned this issue Nov 7, 2023
Merged
12 tasks
This was referenced Nov 21, 2023
Open
Open
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 21, 2023
@gnprice
notif: Support iOS!
75c9501 
Fixes: zulip#321
This was referenced Nov 21, 2023
Merged
Closed
chrisbobbe pushed a commit that referenced this issue Nov 22, 2023
@gnprice @chrisbobbe
notif: Support iOS!
69574ae 
Fixes: #321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications
Projects
Flutter app
Status: Done
Milestone
M0: Alpha
Development

Successfully merging a pull request may close this issue.

notif: Support iOS! gnprice/zulip-flutter
1 participant
@gnprice