-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightbox: Use a friendlier format for the date, like "Yesterday at 4:47 PM" #45
Comments
@gnprice can i work on this? |
Sure. Do see our guide to picking an issue: so in particular before claiming an issue, you should have already gotten started working on it, finding the relevant piece of code and getting an idea of how you'll approach it. Also note this issue is in the "Post-launch" milestone, not "Launch" or earlier. That means the core team will have limited time to spend helping with this issue for the next few months. But I think the issue is simple enough that that should be fine. |
@gnprice I had a shot at this issue and is the result The device i am using is my Techno Spark 7 - Before making a PR, I would like to verify if a change like this would require that tests be made or updated? since I just added a method to the widget to format the date. In the course of solving this issue, i added localization to transform the time to the local of the user; it address #278 for this date. |
Changed the timestamp format from Mar 31, 2023 15:09:51 to a more readable Mar 31, 2023 at 3:09 PM. Added proper localization support to adapt timestamps to the user's language and region preferences. Optimized the timestamp logic to ensure accurate categorization into Today, Yesterday, or specific dates. Fixes: zulip#45
Hello, I have worked on the issue, Please review the changes and let me know if anything else is required. |
…or "A few seconds ago", etc.
Currently it shows something like "Mar 31, 2023 15:09:51".
The text was updated successfully, but these errors were encountered: