Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox: Use a friendlier format for the date, like "Yesterday at 4:47 PM" #45

Open
chrisbobbe opened this issue Mar 31, 2023 · 4 comments · May be fixed by #987
Open

lightbox: Use a friendlier format for the date, like "Yesterday at 4:47 PM" #45

chrisbobbe opened this issue Mar 31, 2023 · 4 comments · May be fixed by #987
Labels
a-i18n Translation, localization, internationalization a-lightbox The lightbox / image-viewer screen help wanted

Comments

@chrisbobbe
Copy link
Collaborator

…or "A few seconds ago", etc.

Currently it shows something like "Mar 31, 2023 15:09:51".

@gnprice gnprice added the m-beta label May 26, 2023
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice added a-lightbox The lightbox / image-viewer screen a-i18n Translation, localization, internationalization and removed m-beta labels May 27, 2023
@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@mofirojean
Copy link

@gnprice can i work on this?

@gnprice
Copy link
Member

gnprice commented Oct 2, 2024

Sure. Do see our guide to picking an issue:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on

so in particular before claiming an issue, you should have already gotten started working on it, finding the relevant piece of code and getting an idea of how you'll approach it.

Also note this issue is in the "Post-launch" milestone, not "Launch" or earlier. That means the core team will have limited time to spend helping with this issue for the next few months. But I think the issue is simple enough that that should be fine.

@mofirojean
Copy link

mofirojean commented Oct 5, 2024

@gnprice I had a shot at this issue and is the result

The device i am using is my Techno Spark 7 -
Android 11
Here is the result: the time stamps were changed to a more readable date format

Screenshot_20241005-040206
Screenshot_20241005-041103
Screenshot_20241005-031245
Screenshot_20241005-031431
Screenshot_20241005-031134

Before making a PR, I would like to verify if a change like this would require that tests be made or updated? since I just added a method to the widget to format the date.

In the course of solving this issue, i added localization to transform the time to the local of the user; it address #278 for this date.

@mofirojean mofirojean linked a pull request Oct 5, 2024 that will close this issue
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Dec 22, 2024
Changed the timestamp format from Mar 31, 2023 15:09:51 to a more
readable Mar 31, 2023 at 3:09 PM.
Added proper localization support to adapt timestamps to the user's
language and region preferences.
Optimized the timestamp logic to ensure accurate categorization into
Today, Yesterday, or specific dates.

Fixes: zulip#45
@lakshya1goel
Copy link

Hello, I have worked on the issue, Please review the changes and let me know if anything else is required.
@chrisbobbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-i18n Translation, localization, internationalization a-lightbox The lightbox / image-viewer screen help wanted
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants