Increase content font size #512
Assignees
Labels
a-design
Visual and UX design
a-msglist
The message-list screen, except what's label:a-content
beta feedback
Things beta users have specifically asked for
Milestone
Comments
gnprice
added
a-msglist
|
I want to work on this, to get a better understanding of the project for GSOC. |
|
@vijay-kesanakurthi Ah, we should have marked this sooner — this is actually an issue that a member of the core team is planning to take care of within the next week. I'll mark it as assigned now. There are plenty of other issues on our project board, though, that don't have anyone assigned, so I'd encourage browsing through those. And if you haven't already, please take a look at the Zulip project's guide for picking an issue to work on: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on |
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Feb 29, 2024
…citly kBaseFontSize is currently 14. Before this, the text was sized by Theme.of(context).textTheme.bodyMedium.fontSize, thanks to an AnimatedDefaultTextStyle in the Material widget. That value is 14 when the app's localization state is set to render text as "English-like" (see [Typography]), which at this point I think it always is. We want to increase the content font size soon, for zulip#512, and for that it'll be helpful if everything uses kBaseFontSize or some multiple of it. From scrolling through a bunch of content with kBaseFontSize increased dramatically, I think these were the only pieces of content that weren't doing so.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Feb 29, 2024
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a sub-issue of:
Currently the app's font size for plain text in message bodies is 14px. That dates from the early prototype phase, when I was copying web's design meticulously (to demonstrate that we could).
The corresponding size in the zulip-mobile legacy RN app is 16px, I believe.
The corresponding size in @terpimost's design in Figma is 17px. For example, see here.
So we should increase the size, either to 16px or 17px.
If we're unsure which of those sizes to prefer, we could add a setting (even if only for the beta period) — that would make it easy for beta users to experiment with the different values and take crisp apples-to-apples pairs of screenshots for discussion.
Chat thread: https://chat.zulip.org/#narrow/stream/48-mobile/topic/density.20in.20message.20list/near/1733351
The text was updated successfully, but these errors were encountered: