Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess spacing between sender and paragraph #513

Closed
gnprice opened this issue Feb 9, 2024 · 0 comments · Fixed by #542
Closed

Excess spacing between sender and paragraph #513

gnprice opened this issue Feb 9, 2024 · 0 comments · Fixed by #542
Assignees
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@gnprice
Copy link
Member

gnprice commented Feb 9, 2024

From a thread on white space vs. density in the message list:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/density.20in.20message.20list/near/1735032

We currently have 8px of vertical space between the bottom of a sender avatar and the top of a paragraph, if that's the start of the message. The design shows 4px.

Specifically we have 4px between the avatar and the message content, and then our Paragraph widget has 4px top and bottom padding around the underlying Text.

I think fixing this properly will basically involve taking care of #162 — going through and properly allocating all the vertical padding between messages, between sender and body, and around and between paragraphs, list items, quotes, images, and all the rest. That's one aspect of copying web's design that I skipped in the early prototype, and we haven't yet returned to (which is why it's an open issue).

But e.g. one easy hack would be to cut the 4px below the sender, and count on the content's first child to have its own top padding. That might be worth doing, pending #162. (Which is a task we're holding off on for the moment because there's some work happening now/soon on web that should have a side effect of making the task easier for us; details there.)

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-design Visual and UX design beta feedback Things beta users have specifically asked for labels Feb 9, 2024
@gnprice gnprice added this to the Beta 2 milestone Feb 9, 2024
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Mar 1, 2024
This is the "easy hack" Greg mentions in the description of zulip#513.

Related: zulip#513
@gnprice gnprice closed this as completed in b20d84e Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants