Skip to content

Fix "private"/"PM" stragglers on the internal side of our API bindings #785

Open
@gnprice

Description

@gnprice

This is a partial revival of:

@PIG208 noticed at #145 (comment) that we have MessageType.private, which uses the old nomenclature. It should be MessageType.direct.

Similarly we have InitialSnapshot.recentPrivateConversations; it should be InitialSnapshot.recentDmConversations.

Both of those names reflect what's in the server API. We should use JsonKey and friends so that we continue to interact with the API in the same way, and just have the modernized names within our code.

After doing those two renames, rerun this search command to look for any remaining stragglers:

$ git grep -P 'pm|Pm|PM|(?i:private)' -- lib test

Metadata

Metadata

Assignees

No one assigned

    Labels

    a-apiImplementing specific parts of the Zulip server API

    Type

    No type

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions