Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade Flutter to 3.27.0-1.0.pre.166 #1018

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Oct 22, 2024

And update Flutter's supporting libraries to match.

Built successfully on my Android device; still need to confirm that it works on IOS.
This contains a major version bump to the dart SDK (changelog).

3.7.0 adds Wildcard Variables, that we currently doesn't seem to use.

There is also changes to the Dart to Javascript Compiler (dart2js) and Dart Development Compiler (dartdevc), both are "switched to use an AOT snapshot instead of a JIT snapshot". Neither of them applies to us because we do not use the web builds.

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Oct 22, 2024

still need to confirm that it works on IOS.

Yup, just tested on an iOS simulator and it works there too. Thanks; LGTM! Marking for Greg's review.

@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Oct 22, 2024
@chrisbobbe chrisbobbe requested a review from gnprice October 22, 2024 21:06
And update Flutter's supporting libraries to match.
@gnprice
Copy link
Member

gnprice commented Oct 23, 2024

Thanks for taking care of this! Looks good; merging.

The Dart version bump is from 3.6.0-etc to 3.7.0-etc, so I'd call that a minor-version bump; the major version is just 3.

We definitely don't yet use wildcard variables, because as the changelog says:

Dart 3.7 adds wildcard variables to the language. To use them, set your package's SDK constraint lower bound to 3.7 or greater (sdk: '^3.7.0').

they only become allowed once you bump the Dart version bound in your pubspec to at least 3.7.0, as this PR does 🙂

@gnprice gnprice merged commit 91f1461 into zulip:main Oct 23, 2024
1 check passed
@PIG208 PIG208 deleted the upgrade branch October 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants