Prep for bottom tabs and main menu #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are extracted because we will later make them accessible as bottom tabs on the HomePage. Among those bottom tabs, the "Users" page (not yet implemented) and MessageListPage are skipped. These are out-of-scope of as now. See Figma for the available tabs: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3307-50151&node-type=frame&t=hGZtzX2QTLse81un-0 Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
…celBg Also switched to .fromMap for better readability Signed-off-by: Zixuan James Li <zixuan@zulip.com>
The icons are taken from Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=544-22131&node-type=canvas&t=f4vYPq2CZUpFuf7V-0 Signed-off-by: Zixuan James Li <zixuan@zulip.com>
gnprice
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks! These LGTM. @chrisbobbe, does this cover all your review comments from #1076 that apply to these commits?
|
Yep, LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested here: #1076 (review)
These are some of the prep commits picked from #1076.