Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for RawAutocomplete #1190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victorsanni
Copy link

The fixes to RawAutocomplete's options width in the flutter framework (flutter/flutter#143249) introduces a frame delay, so this test requires an extra pump to account for that.

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 20, 2024

Welcome, @victorsanni! Are you here because you chose option 2 of the broken-test policy of the Flutter Customer Test Registry?

  1. Go through the breaking change process, as documented here: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes If you're going to do this, you will need to contact the relevant people responsible for the breaking test(s) (see the relevant .test files), help them fix their code, and update this repository to use the new version of their tests, in addition to the steps described on the wiki. You will also need to land your change in two parts, so that people have time to migrate (a "soft-breaking" change).

I'd like to better understand the rationale for this breaking change. A frame delay doesn't sound ideal; can your bugfixes be done without it? If not, I'd like to see an explanation.

@victorsanni
Copy link
Author

victorsanni commented Dec 20, 2024

Hi @chrisbobbe! Indeed I am here for that reason.

The associated Flutter framework PR fixes the issue where the RawAutocomplete widget goes out of the screen from the right side. But the tradeoff was that unfortunately, the layout of the options view doesn't update on the same frame that the field layout changes.

@gnprice suggested some ideas on how to eliminate the one frame delay, which I implemented in the PR to make the options view relayout when the constraints given to the field change. However, there are still cases where the frame delay remains, which (I think) is causing the failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants