Use now-upstream ScrollView.paintOrder, replacing CustomPaintOrderScrollView #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update Flutter's supporting libraries to match. In particular this pulls in two recent PRs of mine so we can use them: flutter/flutter#166730 flutter/flutter#164818
The functionality provided by CustomPaintOrderScrollView is now available upstream, since my PR adding it landed: flutter/flutter#164818
This functionality is now covered by [ScrollView.paintOrder], after my PR adding that feature upstream.
|
Thanks, LGTM! Merged. |
|
Oops, not having run this locally, I missed something: the new minimum Flutter version in the Flutter upgrade commit— —contains flutter/flutter@09d4dab, which causes a change in an iOS file when I run diff --git ios/Flutter/AppFrameworkInfo.plist ios/Flutter/AppFrameworkInfo.plist
index 7c5696400..1dc6cf765 100644
--- ios/Flutter/AppFrameworkInfo.plist
+++ ios/Flutter/AppFrameworkInfo.plist
@@ -21,6 +21,6 @@
<key>CFBundleVersion</key>
<string>1.0</string>
<key>MinimumOSVersion</key>
- <string>12.0</string>
+ <string>13.0</string>
</dict>
</plist> |
|
Ah good catch, thanks. Would you send a quick PR to update that? This is an example of where it'd be handy to have #773, building for iOS in our CI. |
|
In fact I guess our minimum is already iOS 14 in zulip-mobile, as I found when checking here: So we should probably increase it further to there. |
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
May 1, 2025
The Flutter doc on deploying an iOS app says this number should match the deployment target we set in Xcode (which we also specify in ios/Podfile): https://docs.flutter.dev/deployment/ios#updating-the-apps-deployment-version ; sure, go ahead and update it. Prompted by noticing that `flutter run` started bumping it to 13.0 (in flutter/flutter@09d4dabd6; see discussion: zulip#1489 (comment) ) and realizing that 14.0 is actually what it should be for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit messages
47273ce deps: Upgrade Flutter to 3.32.0-1.0.pre.257
And update Flutter's supporting libraries to match.
In particular this pulls in two recent PRs of mine so we can
use them:
flutter/flutter#166730
flutter/flutter#164818
7b5ed74 scroll [nfc]: Use now-upstream ScrollView.paintOrder
The functionality provided by CustomPaintOrderScrollView is now
available upstream, since my PR adding it landed:
flutter/flutter#164818
705db8c scroll [nfc]: Cut CustomPaintOrderScrollView now that upstream PR merged
This functionality is now covered by [ScrollView.paintOrder],
after my PR adding that feature upstream.