Skip to content

l10n: Update translations from Weblate, except skip zh_Hans #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 21, 2025

Cherry-picked from 5466452, which was in the v0.0.29 preview beta. The cherry-pick required fixup only in rerunning tools/check l10n --fix, which changed the set of English fallback strings included in the new de translation.

This update required adjustment; straight from the Weblate branch, l10n generation (tools/check l10n --fix) failed:

Arb file for a fallback, zh, does not exist, even though
the following locale(s) exist: [zh_Hans].
When locales specify a script code or country code, a
base locale (without the script code or country code) should
exist as the fallback. Please create a {fileName}_zh.arb
file.

The app_zh_Hans.arb file had only two translations in it; it exists at the moment precisely in order to test this sort of workflow. For the release, I just removed it and reran generation. (We'll include it properly in a future change.)

Cherry-picked from 5466452, which
was in the v0.0.29 preview beta.  The cherry-pick required fixup
only in rerunning `tools/check l10n --fix`, which changed the set
of English fallback strings included in the new `de` translation.

This update required adjustment; straight from the Weblate branch,
l10n generation (`tools/check l10n --fix`) failed:

    Arb file for a fallback, zh, does not exist, even though
    the following locale(s) exist: [zh_Hans].
    When locales specify a script code or country code, a
    base locale (without the script code or country code) should
    exist as the fallback. Please create a {fileName}_zh.arb
    file.

The app_zh_Hans.arb file had only two translations in it; it exists
at the moment precisely in order to test this sort of workflow.
For the release, I just removed it and reran generation.
(We'll include it properly in a future change.)
@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label May 21, 2025
@PIG208
Copy link
Member

PIG208 commented May 21, 2025

Thanks! While I do see some changes in the Weblate remote since this was written, I think we will just synchronize translations from there after merging this.

@PIG208 PIG208 merged commit 4effb82 into zulip:main May 21, 2025
1 check passed
@PIG208
Copy link
Member

PIG208 commented May 21, 2025

Merged. Now I will try to get the Weblate remote up-to-date, since this has some conflicts with the recent updates I mentioned above.

@PIG208 PIG208 mentioned this pull request May 21, 2025
@gnprice gnprice deleted the pr-sync-translations branch May 22, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants