msglist test: Call checkInvariants on checkNotNotified. #769
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Jun 28, 2024
test/model/message_list_test.dart
Outdated
| checkNotified(count: 0); | ||
| checkInvariants(model); |
There was a problem hiding this comment.
Let's swap the order:
- that matches what happens in the
checkNotifiedcase; - if both checks would fail, then the fact that invariants were broken is probably closer to the root of the issue and so the more helpful one to report.
PIG208
force-pushed
the
notified
branch
2 times, most recently
from
baca9ac to
29f11e6
Compare
We already always check the invariants through a listener on the MessageListView instance. Now we do it more consistently when not notified. Signed-off-by: Zixuan James Li <zixuan@zulip.com>
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stemmed from #766 (comment).
We already always check the invariants through a listener on the MessageListView instance. Now we do it more consistently when not notified.