fake_api [nfc]: Add delay option to connection.prepare
#770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
force-pushed
the
pr-fake-api-delay
branch
from
e3d4c35 to
c1a32f7
Compare
|
LGTM, thanks! I'll hold off on merging so @sm-sayedi can take a look; I see you've requested his review. |
|
Looks good to me too. Thanks for this @gnprice. |
This allows simulating a request that takes some time to return and consequently races with something else. For example here: zulip#713 (comment) This is NFC because `Future.delayed(Duration.zero, f)` is exactly equivalent to `Future(f)`. (The docs aren't real clear on this; but reading the implementations confirms they boil down to the very same `Timer` constructor call, and then the docs do seem to be trying to say that when read in light of that information.)
gnprice
force-pushed
the
pr-fake-api-delay
branch
from
c1a32f7 to
4a906d5
Compare
|
Merged. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows simulating a request that takes some time to return and consequently races with something else. Useful for situations like at #713 (comment) .
This is NFC because
Future.delayed(Duration.zero, f)is exactly equivalent toFuture(f). (The docs aren't real clear on this; but reading the implementations confirms they boil down to the very sameTimerconstructor call, and then the docs do seem to be trying to say that when read in light of that information.)