msglist: Implement MessageListTheme, with dark-theme colors #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
|
Just because web has a dark-theme variant for this color, and the Figma doesn't yet. (Web actually expresses this with separate `color` and `opacity` attributes. We just collapse those into a Color with the right alpha.)
For the background color, the unread-marker color seems like a very reasonable starting point, since that's what we're using in light theme. White seems reasonable for dark theme, just like in light theme. There shouldn't be an issue with contrast; I expect the background will be darker, if anything, in dark theme. We can always refine these styles later.
The dark-theme variant is copied from the web app. We'll cover the other items one by one, for ease of review, next.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
The dark-theme variant is copied from the web app.
Web expresses this as separate `color` and `opacity` attributes. We combine those attributes into a single Color, where the alpha is the alpha from `color` multiplied by the `opacity`. So, for light theme: 1 * 0.8 = 0.8 And for dark theme: 0.75 * 0.8 = 0.6
…ad hoc This should have more reasonable contrast, but we need an approved color from Vlad.
gnprice
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Thanks! The code all looks great, and I manually tested a bit and everything looks good.
Merging. This commit disappeared in the rebase:
909633e msglist [nfc]: Set text color in MarkAsReadWidget, matching default
because it effectively happened as part of 0d577a0 / #710 (I think with some code you supplied in a review).
Comment on lines
+61
to
+62
| // TODO(#95) need proper dark-theme color (this is ad hoc) | ||
| editedMovedMarkerCollapsed: const Color.fromARGB(128, 214, 202, 194), |
There was a problem hiding this comment.
For this and any similar spots that come up, I think the strategy will probably be:
- Pick something reasonable, as you did here.
- When dark theme is otherwise ready, ship it, and close ui: Implement dark theme #95.
- File a follow-up issue to track Vlad looking around in the app for anything he'd like to tweak about dark theme, and us applying those changes. In that issue, mention this and any other such items as areas for him to particularly look at.
gnprice
force-pushed
the
pr-message-list-theme
branch
from
9028695 to
124f81f
Compare
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 4, 2024
After sweeping through the message-list screen to implement dark theme (zulip#843), in late July, the Flutter framework merged flutter/flutter#143501, in early August. This made it so our `foregroundColor` no longer controlled the icon color, as promised in the dartdocs of `foregroundColor` and `iconColor`. I commented about this on the PR: flutter/flutter#143501 (comment) Fixes: zulip#926
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 4, 2024
After sweeping through the message-list screen to implement dark theme (zulip#843), in late July, the Flutter framework merged flutter/flutter#143501, in early August. This made it so our `foregroundColor` no longer controlled the icon color, as promised in the dartdocs of `foregroundColor` and `iconColor`. I commented about this on that Flutter PR thread just now: flutter/flutter#143501 (comment) Fixes: zulip#926
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 4, 2024
After sweeping through the message-list screen to implement dark theme (zulip#843), in late July, the Flutter framework merged flutter/flutter#143501, in early August. This made it so our `foregroundColor` no longer controlled the icon color, as promised in the dartdocs of `foregroundColor` and `iconColor`. I opened an issue for Flutter about the inconsistency with the doc: flutter/flutter#154644 and sent a PR to resolve it, by updating the doc (which the author of 143501 had said was the right fix): flutter/flutter#154646 Fixes: zulip#926
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 9, 2024
After sweeping through the message-list screen to implement dark theme (zulip#843), in late July, the Flutter framework merged flutter/flutter#143501, in early August. This made it so our `foregroundColor` no longer controlled the icon color, as promised in the dartdocs of `foregroundColor` and `iconColor`. I opened an issue for Flutter about the inconsistency with the doc: flutter/flutter#154644 and sent a PR to resolve it, by updating the doc (which the author of 143501 had said was the right fix): flutter/flutter#154646 Fixes: zulip#926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #95