Sketch removing notification when message read #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group summaries naturally don't have this extra. And on the other hand both the group summaries and the individual notifications have a wide range of other extras we didn't put there, with a variety of types.
Android Studio makes this change automatically when I open the android/ subtree as a project. Probably we should add some form of this to the repo so Android Studio doesn't try to do it automatically. But a mergeable version will need to include the referenced `.iml` file too.
|
This became #878, which is now merged. Thanks @rajveermalviya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341.
This is a draft that isn't meant to be merged. But in my manual testing, it does work!
I originally wrote this in March, as described at #341 (comment) , and it became the impetus to start work on #351 converting to use Pigeon. So the bulk of that draft branch turned into #592.
This draft PR is the result of me taking the rest of the material from that draft branch and rebasing it. Some of it may be a bit rough because it was part of our first experiment with Pigeon. The commit structure is rough because I left it mostly as it was in the draft branch, only squashing a couple of fixup commits.
Things this needs before we can ship it:
Use the binding instead of the host API directly, so tests are possible.
Write a few tests.
Clean up the commits. A good structure might look like: add one Pigeon method, add the other, then make the
lib/notifications/display.dartchanges.To do that, probably just squash everything together and then split into new commits.
Maybe handle the TODO on
getActiveNotificationsto accept a list of extras to care about, so that we don't take a whole bunch of irrelevant extras and try to serialize them back to Dart.So @rajveermalviya please take it from here for #341.