-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notif: Handle remove notification message #878
Merged
+682
−10
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a859e8a
pigeon: Add binding for getActiveNotifications
rajveermalviya f230423
pigeon: Add binding for cancel
rajveermalviya 3f09922
notif: Handle remove notification message
rajveermalviya 1d65da7
notif test [nfc]: Make messages list returned by `getActiveNotificati…
rajveermalviya d062713
notif [nfc]: Make shorter local alias for ZulipBinding.instance.andro…
gnprice 58d6c28
notif [nfc]: Keep more comments in remove-notif from zulip-mobile imp…
gnprice b521c45
notif [nfc]: Clarify meaning of last-message-ID extra
gnprice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This semantics works fine since it covers the one use case we actually have — it's definitely simpler to think about than the one in my draft, and that's a good improvement.
It needs to be described in the method's doc, though (in
pigeon/notification.dart
). It looks to be:If not written down explicitly, that's the sort of thing that could lead to some confused time spent debugging when someone in the future tries to add a number or a boolean or something, and then it just doesn't show up — they'd wonder if they typoed the key, or if the extra didn't make it onto the notification for some reason, or what.