Skip to content

Commit

Permalink
SlideAnimationView: Delete.
Browse files Browse the repository at this point in the history
We've just replaced our only use of this with something that has a
better API; see discussion [1].

Also, its interface seemed a little confused -- if it was meant to
"slide" something, I wouldn't expect callers themselves to have to
specify, e.g., `translateX` or `translateY`, over things that
clearly don't make things slide, like `rotateX` or `skewX` [2].

[1] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60View.60's.20.60onLayout.60.20prop/near/1110130
[2] https://reactnative.dev/docs/transforms
  • Loading branch information
chrisbobbe committed Jan 28, 2021
1 parent 20e3dab commit 3d97512
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 56 deletions.
55 changes: 0 additions & 55 deletions src/common/SlideAnimationView.js

This file was deleted.

1 change: 0 additions & 1 deletion src/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export { default as SearchInput } from './SearchInput';
export { default as SectionHeader } from './SectionHeader';
export { default as SectionSeparator } from './SectionSeparator';
export { default as SectionSeparatorBetween } from './SectionSeparatorBetween';
export { default as SlideAnimationView } from './SlideAnimationView';
export { default as SmartUrlInput } from './SmartUrlInput';
export { default as SpinningProgress } from './SpinningProgress';
export { default as GroupAvatar } from './GroupAvatar';
Expand Down

0 comments on commit 3d97512

Please sign in to comment.