example data: Add displayRecipientFromUsers.

And show how to use it. [1] [1] #4187 (comment)
zulip · Sep 22, 2020 · 917886d · 917886d
1 parent ce53787
commit 917886d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 38 deletions.
diff --git a/src/__tests__/lib/exampleData.js b/src/__tests__/lib/exampleData.js
@@ -247,6 +247,9 @@ export const displayRecipientFromUser = (user: User): PmRecipientUser => {
   });
 };
 
+export const displayRecipientFromUsers = (users: User[]): PmRecipientUser[] =>
+  users.map(user => displayRecipientFromUser(user));
+
 /** Boring properties common to all example Message objects. */
 const messagePropertiesBase = deepFreeze({
   isOutbox: false,

diff --git a/src/pm-conversations/__tests__/pmConversationsSelectors-test.js b/src/pm-conversations/__tests__/pmConversationsSelectors-test.js
@@ -31,26 +31,17 @@ describe('getRecentConversations', () => {
   test('returns unique list of recipients, includes conversations with self', () => {
     const meAndJohnPm1 = eg.pmMessage({
       id: 1,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userJohn),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userJohn]),
     });
 
     const meAndMarkPm = eg.pmMessage({
       id: 2,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userMark),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userMark]),
     });
 
     const meAndJohnPm2 = eg.pmMessage({
       id: 3,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userJohn),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userJohn]),
     });
 
     const meOnlyPm = eg.pmMessage({
@@ -60,11 +51,7 @@ describe('getRecentConversations', () => {
 
     const meJohnAndMarkPm = eg.pmMessage({
       id: 0,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userMark),
-        eg.displayRecipientFromUser(userJohn),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userMark, userJohn]),
     });
 
     const state = eg.reduxState({
@@ -155,43 +142,27 @@ describe('getRecentConversations', () => {
 
     const meAndMarkPm1 = eg.pmMessage({
       id: 1,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userMark),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userMark]),
     });
 
     const meAndJohnPm1 = eg.pmMessage({
       id: 2,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userJohn),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userJohn]),
     });
 
     const meAndMarkPm2 = eg.pmMessage({
       id: 3,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userMark),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userMark]),
     });
 
     const meAndJohnPm2 = eg.pmMessage({
       id: 4,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userJohn),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userJohn]),
     });
 
     const meJohnAndMarkPm = eg.pmMessage({
       id: 5,
-      display_recipient: [
-        eg.displayRecipientFromUser(eg.selfUser),
-        eg.displayRecipientFromUser(userJohn),
-        eg.displayRecipientFromUser(userMark),
-      ],
+      display_recipient: eg.displayRecipientFromUsers([eg.selfUser, userJohn, userMark]),
     });
 
     const meOnlyPm = eg.pmMessage({