native ios: Rename ZLPInfoProperties to ZLPConstants.

We're about to expose a constant here that doesn't come from the
Info.plist (the "information property list file") [1]. It seems
silly to make a new NativeModule for the new constant, so, rename
the file so it makes sense for both constants.

[1]: https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/AboutInformationPropertyListFiles.html

ios/ZulipMobile.xcodeproj/project.pbxproj

@@ -12,7 +12,7 @@
 		13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; };
 		13B07FC11A68108700A75B9A /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.m */; };
 		42689E9C23466FF7007540AA /* webview in Resources */ = {isa = PBXBuildFile; fileRef = 42689E9B23466FF7007540AA /* webview */; };
-		8BEA1EF024A6983D00674040 /* ZLPInfoProperties.m in Sources */ = {isa = PBXBuildFile; fileRef = 8BEA1EEE24A6983D00674040 /* ZLPInfoProperties.m */; };
+		8BEA1EF024A6983D00674040 /* ZLPConstants.m in Sources */ = {isa = PBXBuildFile; fileRef = 8BEA1EEE24A6983D00674040 /* ZLPConstants.m */; };
 		A148FEFC1E9D8CB900479280 /* zulip.mp3 in Resources */ = {isa = PBXBuildFile; fileRef = A148FEFB1E9D8CB900479280 /* zulip.mp3 */; };
 		C091D09FD11FDDB8E939257D /* libPods-ZulipMobile.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 74F3CD22CB932FA7EEE0BB66 /* libPods-ZulipMobile.a */; };
 		CFA67D201EC23BCB0070048E /* UtilManager.m in Sources */ = {isa = PBXBuildFile; fileRef = CFA67D1F1EC23BCB0070048E /* UtilManager.m */; };
@@ -33,8 +33,8 @@
 		42689E9B23466FF7007540AA /* webview */ = {isa = PBXFileReference; lastKnownFileType = folder; path = webview; sourceTree = "<group>"; };
 		66E34CC6219226D10091B852 /* ZulipMobile-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "ZulipMobile-Bridging-Header.h"; sourceTree = "<group>"; };
 		74F3CD22CB932FA7EEE0BB66 /* libPods-ZulipMobile.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ZulipMobile.a"; sourceTree = BUILT_PRODUCTS_DIR; };
-		8BEA1EEE24A6983D00674040 /* ZLPInfoProperties.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = ZLPInfoProperties.m; path = ZulipMobile/ZLPInfoProperties.m; sourceTree = "<group>"; };
-		8BEA1EEF24A6983D00674040 /* ZLPInfoProperties.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ZLPInfoProperties.h; path = ZulipMobile/ZLPInfoProperties.h; sourceTree = "<group>"; };
+		8BEA1EEE24A6983D00674040 /* ZLPConstants.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = ZLPConstants.m; path = ZulipMobile/ZLPConstants.m; sourceTree = "<group>"; };
+		8BEA1EEF24A6983D00674040 /* ZLPConstants.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ZLPConstants.h; path = ZulipMobile/ZLPConstants.h; sourceTree = "<group>"; };
 		A148FEFB1E9D8CB900479280 /* zulip.mp3 */ = {isa = PBXFileReference; lastKnownFileType = audio.mp3; path = zulip.mp3; sourceTree = "<group>"; };
 		CF6CFE2C1E7DC55100F687C7 /* Build-Phases */ = {isa = PBXFileReference; lastKnownFileType = folder; path = "Build-Phases"; sourceTree = "<group>"; };
 		CFA67D1F1EC23BCB0070048E /* UtilManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = UtilManager.m; path = ZulipMobile/UtilManager.m; sourceTree = "<group>"; };
@@ -60,8 +60,8 @@
 		13B07FAE1A68108700A75B9A /* ZulipMobile */ = {
 			isa = PBXGroup;
 			children = (
-				8BEA1EEF24A6983D00674040 /* ZLPInfoProperties.h */,
-				8BEA1EEE24A6983D00674040 /* ZLPInfoProperties.m */,
+				8BEA1EEF24A6983D00674040 /* ZLPConstants.h */,
+				8BEA1EEE24A6983D00674040 /* ZLPConstants.m */,
 				3C4249EC1EF6E16500D245F1 /* ZulipMobile.entitlements */,
 				008F07F21AC5B25A0029DE68 /* main.jsbundle */,
 				13B07FAF1A68108700A75B9A /* AppDelegate.h */,
@@ -365,7 +365,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				CFA67D201EC23BCB0070048E /* UtilManager.m in Sources */,
-				8BEA1EF024A6983D00674040 /* ZLPInfoProperties.m in Sources */,
+				8BEA1EF024A6983D00674040 /* ZLPConstants.m in Sources */,
 				13B07FBC1A68108700A75B9A /* AppDelegate.m in Sources */,
 				13B07FC11A68108700A75B9A /* main.m in Sources */,
 			);

ios/ZulipMobile/ZLPConstants.h

@@ -0,0 +1,5 @@
+#import <React/RCTBridgeModule.h>
+
+@interface ZLPConstants : NSObject <RCTBridgeModule>
+
+@end

ios/ZulipMobile/ZLPInfoProperties.m → ios/ZulipMobile/ZLPConstants.m

@@ -1,6 +1,6 @@
-#import "ZLPInfoProperties.h"
+#import "ZLPConstants.h"
 
-@implementation ZLPInfoProperties
+@implementation ZLPConstants
 
 RCT_EXPORT_MODULE()
 
@@ -13,10 +13,9 @@ + (BOOL)requiresMainQueueSetup
 
 - (NSDictionary *)constantsToExport
 {
-  // Items from the Info.plist.
   return @{
-           // We've added a custom entry that gives us the App ID
-           // Prefix (a.k.a. the Team ID plus a dot). Access it.
+           // In the Info.plist, our custom entry for the App ID
+           // Prefix (a.k.a. the Team ID plus a dot).
            @"appIdentifierPrefix": [[NSBundle mainBundle] objectForInfoDictionaryKey:@"AppIdentifierPrefix"] ?: [NSNull null],
            };
 }