Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on @-mentioning someone who won't see it because not subscribed #3373

Closed
opensource21 opened this issue Feb 28, 2019 · 3 comments · Fixed by #4101
Closed

Warn on @-mentioning someone who won't see it because not subscribed #3373

opensource21 opened this issue Feb 28, 2019 · 3 comments · Fixed by #4101
Assignees
@agrawal-d
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority

Comments

@opensource21
Copy link

Referenced users do not receive notifications from unsubscribed streams. See github issue. Unfortunately there is no warning at mobile-client :-( This is a ugly pitfall if you think you have notice someone, but the person didn't get any information.
See https://chat.zulip.org/#narrow/stream/48-mobile/topic/Referenced.20users.20on.20unsubscribed.20streams/near/709487
@timabbott
Copy link
Member

Yeah, we should fix this.

For this category of things, there's a few parts of the webapp code we may want to study/adapt.

  • exports.notify_local_mixes in static/js/notifications.js (things we do after you send a message)
  • validate_stream_message_mentions and the handful of functions after it in static/js/compose.js (validation/warnings/etc. we do before you send a message)
  • The $(document).on('usermention_completed.zulip', function (event, data) { handler in static/js/compose.js, which is where the webapp checks for this particular issue (this happens right after completing the mention in the typeahead)

@borisyankov borisyankov self-assigned this Feb 28, 2019
@chrisbobbe chrisbobbe added a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-notifications labels Feb 13, 2020
@gnprice gnprice changed the title Referenced users on unsubscribed streams Warn on @-mentioning someone who won't see it because not subscribed Feb 13, 2020
@gnprice
Copy link
Member

gnprice commented Feb 13, 2020

Bumping the priority, because this can be pretty frustrating for everyone involved when it happens.

@agrawal-d agrawal-d self-assigned this May 7, 2020
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue May 12, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
7bdbe42 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Set up pipeline to enable the same.

Closes zulip#3373.
@agrawal-d agrawal-d mentioned this issue May 13, 2020
Closed
@chrisbobbe
Copy link
Contributor

Looks like zulip/zulip#14966 was just closed, so work on this can continue! 🙂 Thanks @akashaviator and @timabbott!

agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jun 12, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
fd66ed6 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Set up pipeline to enable the same.

Closes zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jun 12, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
b1454cb 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Set up pipeline to enable the same.

Fixes: zulip#3373.
@agrawal-d agrawal-d mentioned this issue Jun 12, 2020
Merged
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jun 15, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
b722eae 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jun 15, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
27e53f3 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 4, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
03d9811 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 4, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
3cb3ea1 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 31, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
778406a 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jul 31, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
61aef12 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Aug 4, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
502d337 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Aug 4, 2020
@agrawal-d
autocomplete: Warn on @-mention when user is not subscribed.
dcdb454 
Show a warning when @-mentioning a user who is not subscribed to
the stream the user was mentioned in, with an option to subscribe
them to the stream. Use the created pipeline in the previous
commits to enable the same.

Fixes: zulip#3373.
@gnprice gnprice closed this as completed in 20bd98a Aug 6, 2020
@gnprice gnprice mentioned this issue Aug 11, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrawal-d agrawal-d

Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn on @-mentioning someone who won't see it because not subscribed agrawal-d/zulip-mobile
6 participants
@gnprice @opensource21 @borisyankov @timabbott @agrawal-d @chrisbobbe