Upgrade to RN v0.62 #3782

gnprice · 2020-01-09T23:46:21Z

Released 2020-03-26. Release notes:
https://reactnative.dev/blog/2020/03/26/version-0.62
and shorter version: https://github.com/facebook/react-native/releases/tag/v0.62.0

(~~This is for a version that isn't released yet 🙂, so there's no work to do on it right now. Filing to have an identifier to refer to this upgrade by.~~)

~~We also won't start real work on this upgrade until after #3781, the upgrade to RN v0.61, is complete.~~ Which it is!

Changes include:

Flow v0.113. In particular this means:
- (Flow v0.106) Changes to object spreads
- (Flow v0.111) More changes to object spreads; see comment below
- (Flow v0.112) Support for method calls in optional chains, like foo?.bar()

The text was updated successfully, but these errors were encountered:

gnprice · 2020-01-27T23:16:21Z

One thing v0.62 is projected to get us is the latest version of the React Developer Tools. See #3801, our docs here, and the react-devtools v4 release notes.

rk-for-zulip · 2020-01-27T23:32:45Z

~~RN 0.62 is expected to come with a version of Flow which will, at long last, make exact object types with indexer properties usable. (See notes in the current jsonable.js for more information.)~~ This seems incorrect; see discussion. It seems this will be fixed, but not until Flow v0.126.

EDIT: There are places other than jsonable.js to which potential improvements are applicable. (I've generally been marking these with comments containing the string v.0.111.0, when I find them.)

EDIT (Chris): facebook/flow#6715 ("Spreading into an object allows a value of undefined for subsequent properties"), as Ray pointed at #4046 (comment); he reports that this is fixed in v0.111.1.

gnprice · 2020-03-27T20:11:24Z

Upstream's list of breaking changes is short, and from a quick grep we don't appear to be affected by any of them.

Advertised improvements include:

Support for Flipper, a developer tool. This is the change upstream seems most excited to talk about. May be handy -- certainly we should play with it once we're on this version!
A small API for getting the user's system-wide preference for a light or dark color scheme. I'd been thinking we should do this, particularly as it's now an OS feature (both Android and iOS) to have the theme change automatically on a daily cycle. I guess since this upgrade is coming and will make it easy, it makes sense to wait for that. (OK, filed as Automatically follow user's OS-level dark/light preference, take 1 #4009.)
We’re adding the new LogBox error and warning experience as an opt-in

Should try this one too, once upgraded.
React DevTools v4, as mentioned above. Specifically:

React DevTools v4: This change includes an upgrade to the latest React DevTools which offers significant performance gains, an improved navigation experience, and full support for React Hooks.

chrisbobbe · 2020-06-10T20:46:27Z

Support for Flipper, a developer tool. This is the change upstream seems most excited to talk about. May be handy -- certainly we should play with it once we're on this version!

I think facebook/react-native@3a66fc7 may have been mistakenly released in RN v0.61 instead of v0.62. It includes some changes to the template app that we've therefore decided not to take as part of the v0.60 -> v0.61 upgrade, as noted at #3781 (comment). So we'll need to do that as part of the v0.62 upgrade. See also discussion.

chrisbobbe · 2020-06-11T23:34:18Z

Just a note so we don't forget it — there's a handy guide, with screenshots, to changing some things via the Xcode UI, at react-native-community/upgrade-support#13.

Until Flow v0.111.0 or later, where we'll be when we upgrade to React Native v0.62.0 (that's issue zulip#3782), exact object types with indexer properties are broken. See more details in src/utils/jsonable.js. In particular, this will help us get userHelpers-test.js type-checked.

chrisbobbe · 2020-07-13T21:07:41Z

Although we should always do our best to keep up with the latest versions of all our dependencies, it initially appears that the list of ones we'll be required to upgrade, for RN v0.62 compatability, is short! Just to see whether the list was long or short, I tried upgrading to v0.62 on a local branch and handled peer dependency warnings one by one. (Of course, there could still be issues that aren't declared in peer dependencies.)

react (as expected)
react-native-webview—I get no errors with the current latest, 10.3.2. I believe we'll have to move to at least 10.1.0 in the same commit as the RN upgrade; see discussion.
jest-expo (if using; see RN v0.61 upgrade followup. #4152): v38.0.2, currently the latest, works fine.

Until Flow v0.111.0 or later, where we'll be when we upgrade to React Native v0.62.0 (that's issue zulip#3782), exact object types with indexer properties are broken. See more details in src/utils/jsonable.js. In particular, this will help us get userHelpers-test.js type-checked.

A reversion of e40c020 and 62621ef. Unfortunately, Jest 26 (the latest), which we'll take in an upcoming commit, doesn't support `jest-expo` at 37 [1]. We can't go past 37 (e.g., to 38.0.2, the latest) until we upgrade to React Native v0.62 (that's zulip#3782). That's because jest-expo's "react" peer dependency was bumped from ~16.9.0 to ~16.11.0 in expo/expo#8310 [2], and we must do that React upgrade atomically with our RN upgrade. The "react-native" peer dependency wasn't touched; it remained at "*". So, I'm left unsure whether it was intentional to drop support for RN v0.61 [3]. Ah well. As we were aware in e40c020: """ If `jest-expo` turns out to be buggy, or the dependency requirements get even more tangled or burdensome, we should feel free to abandon this effort; it's not terrible to have to add boring mocks. """ We may consider adding it back in as a followup to zulip#3782. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] We get errors about jest-expo using `require.requireActual`, which was removed in jestjs/jest#9854, out in v26.0.0-alpha.0. [2] expo/expo@a4cabf30a#diff-4a85ebd1069aff25ee2e5f2b004281ccR33 [3] See react-native-webview/react-native-webview#1445.

With Flow v0.113.0, which we'll get in the RN v0.61 -> v0.62 upgrade (zulip#3782), red flags are raised about this test. Strangely, the test was allowed to expect the `zulipVersion` on an Account to be undefined. In fact, the type for it is `ZulipVersion | null`. The test is based on the false premise that a REALM_INIT action might not have a `zulipVersion` property. `RealmInitAction` states that it will always be there, as a ZulipVersion instance. So, delete the test. If we ever find that there's a legitimate case where it is missing, we'll fix the RealmInitAction type accordingly, and a new test can proceed from there.

With Flow v0.113.0, which we'll get in the RN v0.61 -> v0.62 upgrade (zulip#3782), red flags are raised about this test. Strangely [1], the test was allowed to expect the `zulipVersion` on an Account to be undefined. In fact, the type for it is `ZulipVersion | null`. The test is based on the false premise that a REALM_INIT action might not have a `zulipVersion` property. `RealmInitAction` states that it will always be there, as a ZulipVersion instance. So, delete the test. If we ever find that there's a legitimate case where it is missing, we'll fix the RealmInitAction type accordingly, and a new test can proceed from there. [1] I think the culprit is very likely facebook/flow#6715, which Ray reported as being fixed in Flow v0.111.1, at zulip#4046 (comment)

Until Flow v0.111.0 or later, where we'll be when we upgrade to React Native v0.62.0 (that's issue zulip#3782), exact object types with indexer properties are broken. See more details in src/utils/jsonable.js. In particular, this will help us get userHelpers-test.js type-checked.

With Flow v0.113.0, which we'll get in the RN v0.61 -> v0.62 upgrade (zulip#3782), red flags are raised about this test. Strangely [1], the test was allowed to expect the `zulipVersion` on an Account to be undefined. In fact, the type for it is `ZulipVersion | null`. The test is based on the false premise that a REALM_INIT action might not have a `zulipVersion` property. `RealmInitAction` states that it will always be there, as a ZulipVersion instance. So, delete the test. If we ever find that there's a legitimate case where it is missing, we'll fix the RealmInitAction type accordingly, and a new test can proceed from there. [1] I think the culprit is very likely facebook/flow#6715, which Ray reported as being fixed in Flow v0.111.1, at zulip#4046 (comment)

Until Flow v0.111.0 or later, where we'll be when we upgrade to React Native v0.62.0 (that's issue zulip#3782), exact object types with indexer properties are broken. See more details in src/utils/jsonable.js. In particular, this will help us get userHelpers-test.js type-checked.

Until Flow v0.111.0 or later, where we'll be when we upgrade to React Native v0.62.0 (that's issue #3782), exact object types with indexer properties are broken. See more details in src/utils/jsonable.js. In particular, this will help us get userHelpers-test.js type-checked.

gnprice · 2020-08-04T00:50:09Z

At #4101 (comment) , we just learned of another nice thing we'll get with this upgrade: the newer Flow version will support method calls in optional chains, like foo?.bar() (and IIUC also foo?.bar.baz().)

A reversion of e40c020 and 62621ef. Unfortunately, Jest 26 (the latest), which we'll take in an upcoming commit, doesn't support `jest-expo` at 37 [1]. We can't go past 37 (e.g., to 38.0.2, the latest) until we upgrade to React Native v0.62 (that's zulip#3782). That's because jest-expo's "react" peer dependency was bumped from ~16.9.0 to ~16.11.0 in expo/expo#8310 [2], and we must do that React upgrade atomically with our RN upgrade. The "react-native" peer dependency wasn't touched; it remained at "*". So, I'm left unsure whether it was intentional to drop support for RN v0.61 [3]. Ah, well. As I said in e40c020: """ If `jest-expo` turns out to be buggy, or the dependency requirements get even more tangled or burdensome, we should feel free to abandon this effort; it's not terrible to have to add boring mocks. """ We may consider adding it back in as a followup to zulip#3782. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] We get errors about jest-expo using `require.requireActual`, which was removed in jestjs/jest#9854, out in v26.0.0-alpha.0. [2] expo/expo@a4cabf30a#diff-4a85ebd1069aff25ee2e5f2b004281ccR33 [3] See react-native-webview/react-native-webview#1445.

chrisbobbe · 2020-08-29T04:37:15Z

In the tradition of #3781 (comment) and #3548 (comment), here's a list of changes from the upgrade helper that we won't be doing as part of this upgrade:

Platform-agnostic

A change to .gitattributes. This seems to be an artifact of the rn-diff-purge process; the change was never made in the react-native repo, and it didn't even show up for me in a react-native init at version 0.62.2.
Making App.js (which corresponds to our ZulipMobile.js) @flow strict-local instead of @flow, as in facebook/react-native@e36247030. Ours was already @flow strict-local.
Upgrading babel-jest and @react-native-community/eslint-config, as is done in facebook/react-native@babf67f11. We don't use these dependencies (though we're considering the latter in Add and enable @react-native-community/eslint-config. #4119).

Android

The following comment on the diff in the upgrade helper (it has an orange background):

If you are using Hermes Engine and ProGuard, make sure to update the rules in proguard-rules.pro to what is specified in the documentation for 0.62.

Just like in the v0.60 upgrade, we leave this step to be done naturally in Android: Use Hermes #4131. The doc for v0.60 indicates one line to be added; the v0.62 doc indicates that line plus one more.
In the AndroidManifest.xml, setting android:launchMode="singleTask", corresponding to facebook/react-native@7a4259643. We've already been doing this, since 69bb215. I posted here about this change, just in case it might help us understand some stuff we've been working with about Android "activities".
Updating the Jitpack URL, as done in facebook/react-native@018b7485e. We've decided not to use Jitpack; see Upgrade to RN v0.61 #3781 (comment) and Pre-RN v0.61 changes #4150 (comment).

iOS

A change to ios/RnDiffApp.xcodeproj/xcshareddata/xcschemes/RnDiffApp-tvOS.xcscheme. (We're still not in the TV business. 😉)

Done as part of the RN v0.61 -> v0.62 upgrade. In this commit: - Part of the RN v0.60 -> v0.61 [sic] changes to the template app [1], corresponding to facebook/react-native@3a66fc7dc - A partial reversion of that, in the RN v0.61 -> v0.62 changes to the template app [2], corresponding to facebook/react-native@bb272bacc. It looks like this was prematurely released in RN v0.61 instead of RN v0.62 [3], the latter being where most sources claim Flipper support was added; a list of such sources is on CZO [4]. In that partial reversion, the initialize-Flipper function's only call site is removed. We'll re-enable Flipper atomically with the main upgrade commit, and not before, just to be safe. That will correspond to facebook/react-native@05f5cb534. [1] https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5 [2] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [3] zulip#3782 (comment) [4] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Flipper/near/900499

Done as part of the RN v0.61 -> v0.62 upgrade. In this commit: - Part of the RN v0.60 -> v0.61 [sic] changes to the template app [1], corresponding to facebook/react-native@3a66fc7dc - A partial reversion of that, in the RN v0.61 -> v0.62 changes to the template app [2], corresponding to facebook/react-native@bb272bacc. It looks like this was prematurely released in RN v0.61 instead of RN v0.62 [3], the latter being where most sources claim Flipper support was added; a list of such sources is on CZO [4]. In that partial reversion, the initialize-Flipper function's only call site is removed. We'll re-enable Flipper after the main upgrade commit, not before, just to be safe [5]. That will correspond to facebook/react-native@05f5cb534. [1] https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5 [2] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [3] zulip#3782 (comment) [4] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Flipper/near/900499 [5] zulip#4244 (comment)

chrisbobbe · 2020-09-09T23:33:02Z

Marking as blocked on #4248; see discussion.

Done as part of the RN v0.61 -> v0.62 upgrade. In this commit: - Part of the RN v0.60 -> v0.61 [sic] changes to the template app [1], corresponding to facebook/react-native@3a66fc7dc - A partial reversion of that, in the RN v0.61 -> v0.62 changes to the template app [2], corresponding to facebook/react-native@bb272bacc. It looks like this was prematurely released in RN v0.61 instead of RN v0.62 [3], the latter being where most sources claim Flipper support was added; a list of such sources is on CZO [4]. In that partial reversion, the initialize-Flipper function's only call site is removed. We'll re-enable Flipper after the main upgrade commit, not before, just to be safe [5]. That will correspond to facebook/react-native@05f5cb534. [1] https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5 [2] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2 [3] zulip#3782 (comment) [4] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Flipper/near/900499 [5] zulip#4244 (comment)

gnprice added the blocked on other work To come back to after another related PR, or some other task. label Jan 9, 2020

rk-for-zulip mentioned this issue Jan 9, 2020

Upgrade to Node v12 #3780

Closed

chrisbobbe added the upstream: RN Issues related to an issue in React Native label Feb 5, 2020

gnprice mentioned this issue Mar 27, 2020

Automatically follow user's OS-level dark/light preference, take 1 #4009

Closed

chrisbobbe mentioned this issue Jun 10, 2020

Upgrade to RN v0.61 #3781

Closed

gnprice removed the blocked on other work To come back to after another related PR, or some other task. label Jul 13, 2020

chrisbobbe mentioned this issue Jul 20, 2020

accountsReducer: Remove unhelpful test. #4198

Merged

This was referenced Jul 31, 2020

Prep commits for new avatar_url handling (#4157) #4171

Merged

Warn on @-mentioning someone who won't see it because not subscribed #4101

Merged

chrisbobbe mentioned this issue Aug 27, 2020

android build: Upgrade Gradle to 6.5.1 #4228

Closed

chrisbobbe self-assigned this Aug 29, 2020

This was referenced Sep 1, 2020

Pre-RN v0.61 -> v0.62 upgrade changes #4244

Merged

Upgrade to RN v0.63 #4245

Closed

chrisbobbe mentioned this issue Sep 2, 2020

RN v0.61 -> v0.62 upgrade #4247

Merged

chrisbobbe mentioned this issue Sep 9, 2020

Use Immutable for state.flags. #4252

Open

chrisbobbe mentioned this issue Sep 9, 2020

Upgrade React Navigation v3 and v4. #4249

Merged

chrisbobbe added the blocked on other work To come back to after another related PR, or some other task. label Sep 9, 2020

This was referenced Sep 9, 2020

Upgrade react-navigation to v4 #4248

Closed

Document how we use Flipper. #4255

Closed

chrisbobbe mentioned this issue Sep 18, 2020

RN v0.61 -> v0.62 upgrade followup #4261

Merged

gnprice removed the blocked on other work To come back to after another related PR, or some other task. label Sep 18, 2020

gnprice closed this as completed in #4247 Sep 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to RN v0.62 #3782

Upgrade to RN v0.62 #3782

gnprice commented Jan 9, 2020 •

edited

Loading

gnprice commented Jan 27, 2020 •

edited

Loading

rk-for-zulip commented Jan 27, 2020 •

edited by chrisbobbe

Loading

gnprice commented Mar 27, 2020 •

edited

Loading

chrisbobbe commented Jun 10, 2020 •

edited

Loading

chrisbobbe commented Jun 11, 2020

chrisbobbe commented Jul 13, 2020

gnprice commented Aug 4, 2020

chrisbobbe commented Aug 29, 2020 •

edited

Loading

chrisbobbe commented Sep 9, 2020

Upgrade to RN v0.62 #3782

Upgrade to RN v0.62 #3782

Comments

gnprice commented Jan 9, 2020 • edited Loading

gnprice commented Jan 27, 2020 • edited Loading

rk-for-zulip commented Jan 27, 2020 • edited by chrisbobbe Loading

gnprice commented Mar 27, 2020 • edited Loading

chrisbobbe commented Jun 10, 2020 • edited Loading

chrisbobbe commented Jun 11, 2020

chrisbobbe commented Jul 13, 2020

gnprice commented Aug 4, 2020

chrisbobbe commented Aug 29, 2020 • edited Loading

Platform-agnostic

Android

iOS

chrisbobbe commented Sep 9, 2020

gnprice commented Jan 9, 2020 •

edited

Loading

gnprice commented Jan 27, 2020 •

edited

Loading

rk-for-zulip commented Jan 27, 2020 •

edited by chrisbobbe

Loading

gnprice commented Mar 27, 2020 •

edited

Loading

chrisbobbe commented Jun 10, 2020 •

edited

Loading

chrisbobbe commented Aug 29, 2020 •

edited

Loading