Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't provide 'Reply' option for messages that can't be replied to #3810

Open
rk-for-zulip opened this issue Jan 16, 2020 · 3 comments · Fixed by #3811
Open

Don't provide 'Reply' option for messages that can't be replied to #3810

rk-for-zulip opened this issue Jan 16, 2020 · 3 comments · Fixed by #3811

Comments

@rk-for-zulip
Copy link
Contributor

... e.g. (and possibly i.e.), messages in admin-only streams when the active user is not an admin.

(See also #3528.)
@agrawal-d
Copy link
Member

I'm working on this.

agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jan 16, 2020
@agrawal-d
message list: remove "Reply" action when in group PM narrow
11105a8 
Fixes zulip#3810
@agrawal-d agrawal-d mentioned this issue Jan 16, 2020
Merged
@agrawal-d
Copy link
Member

PR #3811 addresses this.

agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jan 16, 2020
@agrawal-d
message list: remove "Reply" action when in group PM narrow
3677f1b 
Fixes zulip#3810
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jan 21, 2020
@agrawal-d
message list: remove "Reply" action when in topic/ group PM narrow
034bf20 
Fixes zulip#3810
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jan 30, 2020
@agrawal-d
message list: modify "Reply" action when in announcement-only narrow.
51e7a78 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Jan 30, 2020
@agrawal-d
message list: remove "Reply" action when in topic/ group PM narrow.
9c2b533 
Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 1, 2020
@agrawal-d
message list: modify "Reply" action when in announcement-only narrow.
ad9cc39 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 1, 2020
@agrawal-d
message list: remove "Reply" action when in topic/ group PM narrow.
6fe67ca 
Remove the 'Reply' option from messageActionSheet when the user is
in a topic narrow or group private message narrow.

Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 1, 2020
@agrawal-d
message list: modify "Reply" action when in announcement-only narrow.
34dd701 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 1, 2020
@agrawal-d
message list: remove "Reply" action when in topic/ group PM narrow.
a4df35a 
Remove the 'Reply' option from messageActionSheet when the user is
in a topic narrow or group private message narrow.

Fixes zulip#3810.
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 4, 2020
@agrawal-d
message list: Modify "Reply" action when in announcement-only narrow.
666b962 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes zulip#3810.
rk-for-zulip pushed a commit that referenced this issue Feb 4, 2020
@agrawal-d @rk-for-zulip
message list: Modify "Reply" action when in announcement-only narrow.
674f9a2 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes #3810.
@gnprice
Copy link
Member

gnprice commented Feb 4, 2020

Reopening, as explained here: #3811 (review)

@gnprice gnprice reopened this Feb 4, 2020
gnprice added a commit that referenced this issue Feb 4, 2020
@gnprice
Revert "message list: Modify "Reply" action when in announcement-only…
8f58f46 
… narrow."

This reverts commit 674f9a2 (#3811).

That commit fixed only some cases of #3810: it relies on the current
narrow rather than the specific message, and so it misses relevant
messages when we're in a starred narrow, a search, etc.  The right fix
will involve plumbing a different set of data down through these
layers, rather than `isAnnouncementOnly`, so it'll be simpler to do
that fresh than starting from here.
@agrawal-d agrawal-d mentioned this issue Feb 6, 2020
Closed
agrawal-d added a commit to agrawal-d/zulip-mobile that referenced this issue Feb 6, 2020
@agrawal-d
MessageActionSheet: Fix 'Reply' option to work correctly in different…
1caddd5 
… scenarios.

Show 'Reply' option for Outbox messages. Modify 'Reply' option
for announcement-only narrow messages based on whether the user is
an admin.

Fixes zulip#3810.
Maskedman99 pushed a commit to Maskedman99/zulip-mobile that referenced this issue Feb 12, 2020
@agrawal-d @Maskedman99
message list: Modify "Reply" action when in announcement-only narrow.
1bf3073 
Currently, it is possible to select the 'Reply' option from action
sheet when in an announcement-only narrow, even if the user is not
an admin.

Modify 'Reply' option based on whether the user is an administrator.

Fixes zulip#3810.
Maskedman99 pushed a commit to Maskedman99/zulip-mobile that referenced this issue Feb 12, 2020
@gnprice @Maskedman99
Revert "message list: Modify "Reply" action when in announcement-only…
9f02aea 
… narrow."

This reverts commit 674f9a2 (zulip#3811).

That commit fixed only some cases of zulip#3810: it relies on the current
narrow rather than the specific message, and so it misses relevant
messages when we're in a starred narrow, a search, etc.  The right fix
will involve plumbing a different set of data down through these
layers, rather than `isAnnouncementOnly`, so it'll be simpler to do
that fresh than starting from here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gnprice @agrawal-d @rk-for-zulip