Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to @react-native-async-storage/async-storage. #4890

Closed
chrisbobbe opened this issue Jul 9, 2021 · 2 comments · Fixed by #4894
Closed

Switch to @react-native-async-storage/async-storage. #4890

chrisbobbe opened this issue Jul 9, 2021 · 2 comments · Fixed by #4894
Labels
dependencies Pull requests that update a dependency file P1 high-priority

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Jul 9, 2021 •
edited
Loading

@react-native-community/async-storage is marked as deprecated (link), with a sign pointing to @react-native-async-storage/async-storage as the project's new home.

We'll need to read changelog entries and test the app out a bit, to get an idea of what might change. From just a brief look, I get the sense that the new one is a continuation of development on the old one; they're not totally different projects, so I'm hoping the transition will be pretty smooth. If we could find some historical documents describing the rename/change of ownership of the project (or whatever happened) from that time, that'd be really helpful.
@chrisbobbe chrisbobbe added the dependencies Pull requests that update a dependency file label Jul 9, 2021
@chrisbobbe
Copy link
Contributor Author

(This is on the path to #4426 because of a peer-dependency issue.)

@chrisbobbe chrisbobbe mentioned this issue Jul 9, 2021
Closed
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 12, 2021
@chrisbobbe
deps: Remove caret on @react-native-async-storage/async-storage.
9f2964e 
This takes us to v1.15.5, the current latest. No breaking changes
are announced in the changelog [1], but 1.13.3 does announce this:

> After upgrading to v1.13.3+, remember to:
>
> - remove Pods directory (ios/Pods)
> - clean build directory through Xcode (in menu: Product -> Clean
>   Build Folder)
> - install dependencies again (`pod install`)

This didn't seem obviously necessary, but I did it anyway.

v1.13.4 gets us @react-native-async-storage/async-storagefb0ce97e3,
which we'll need for the RN v0.64 upgrade, zulip#4426.

[1] https://github.com/react-native-async-storage/async-storage/releases

Fixes: zulip#4890
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jul 12, 2021
@chrisbobbe
deps: Remove caret on @react-native-async-storage/async-storage.
00fe105 
This takes us to v1.15.5, the current latest. No breaking changes
are announced in the changelog [1], but 1.13.3 does announce this:

> After upgrading to v1.13.3+, remember to:
>
> - remove Pods directory (ios/Pods)
> - clean build directory through Xcode (in menu: Product -> Clean
>   Build Folder)
> - install dependencies again (`pod install`)

This didn't seem obviously necessary, but I did it anyway.

v1.13.4 gets us @react-native-async-storage/async-storagefb0ce97e3,
which we'll need for the RN v0.64 upgrade, zulip#4426.

[1] https://github.com/react-native-async-storage/async-storage/releases

Fixes: zulip#4890
@chrisbobbe chrisbobbe mentioned this issue Jul 12, 2021
Merged
@chrisbobbe
Copy link
Contributor Author

Added P1 to inherit from #4426.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to @react-native-async-storage/async-storage. chrisbobbe/zulip-mobile
1 participant
@chrisbobbe