Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "All streams" link below subscribed streams #5424

Closed
alya opened this issue Jun 23, 2022 · 1 comment · Fixed by #5443
Closed

Move "All streams" link below subscribed streams #5424

alya opened this issue Jun 23, 2022 · 1 comment · Fixed by #5443
Labels
a-navigation help wanted P1 high-priority redesign Belonging to redesign project

Comments

@alya
Copy link
Collaborator

alya commented Jun 23, 2022

At present, the Streams screen has two tabs -- "Subscribed", and "All streams".

However, in the mobile app, the Subscribed tab is much more commonly useful than the "All streams" tab.

We should:

  1. Replace the tab navigation at the top with a single "Streams" heading. Only subscribed streams will be shown.
  2. Add an "All streams" link at the bottom that takes the user to the view that shows both subscribed and unsubscribed streams. (Title bar: "All streams")

CZO discussion
@gnprice gnprice added the redesign Belonging to redesign project label Jun 23, 2022
@gnprice
Copy link
Member

gnprice commented Jul 13, 2022

As a quick pointer: the existing code for these screens lives in src/main/StreamTabsScreen.js and the two components SubscriptionsCard and StreamListCard that it invokes.

@nol13 nol13 mentioned this issue Jul 17, 2022
Merged
nol13 added a commit to nol13/zulip-mobile that referenced this issue Jul 19, 2022
@nol13
nav: Change the streams tab from a tab navigator to a stack navigator.
9d200b8 
This removes StreamTabsScreen and sets the streams tab in
MainTabsScreen to a stack navigator, with SubscriptionsScreen on
top, and a button at the bottom of SubscriptionsScreen to navigate
to StreamListScreen.

I have tested this in an Android emulator but I have not yet run it
on iOS.

Fixes zulip#5424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-navigation help wanted P1 high-priority redesign Belonging to redesign project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change streams tabs to a stack, initially show subscribed only, issue #5424 nol13/zulip-mobile
2 participants
@gnprice @alya