-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new URLs for direct message searches #5692
Labels
P1 high-priority
server release goal
Things we should try to coordinate with a major Zulip Server release.
Comments
I'm marking this as a server release goal, since it would be good to complete this part of the migration for the 7.0 release. |
11 tasks
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this issue
Mar 30, 2023
These are synonymous with '/pm-with/…' and '/is/private', respectively, and they'll start appearing in messages on newer servers, as part of the renaming of "private message" to "direct message". Mobile still generates links with the old '/pm-with/…' format in quote-and-reply. Those will still probably be supported indefinitely, but it'd be cleanest to switch to generating the new format, with a feature-level condition. Once the server/web-app merge code that uses the new format, we'll know what feature level to use. Fixes: zulip#5692
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this issue
Mar 31, 2023
These are synonymous with '/pm-with/…' and '/is/private', respectively, and they'll start appearing in messages on newer servers, as part of the renaming of "private message" to "direct message". Mobile still generates links with the old '/pm-with/…' format in quote-and-reply. Those will still probably be supported indefinitely, but it'd be cleanest to switch to generating the new format, with a feature-level condition. Once the server/web-app merge code that uses the new format, we'll know what feature level to use. Fixes: zulip#5692
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this issue
Mar 31, 2023
These are synonymous with '/pm-with/…' and '/is/private', respectively, and they'll start appearing in messages on newer servers, as part of the renaming of "private message" to "direct message". Mobile still generates links with the old '/pm-with/…' format in quote-and-reply. Those will still probably be supported indefinitely, but it'd be cleanest to switch to generating the new format, with a feature-level condition. Once the server/web-app merge code that uses the new format, we'll know what feature level to use. Fixes: zulip#5692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P1 high-priority
server release goal
Things we should try to coordinate with a major Zulip Server release.
In zulip/zulip#24806, we have a plan to update URLs used for filters related to direct messages do reflect the new "direct message" (previously: "private message") terminology.
To unblock this, the mobile app needs to support the new URL format.
The text was updated successfully, but these errors were encountered: