Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote and reply deletes topic and moves cursor to topic #5718

Closed
samtuke opened this issue Apr 7, 2023 · 2 comments · Fixed by #5723
Closed

Quote and reply deletes topic and moves cursor to topic #5718

samtuke opened this issue Apr 7, 2023 · 2 comments · Fixed by #5723

Comments

@samtuke
Copy link

samtuke commented Apr 7, 2023

Using quote and reply always results in me:
Starting to type a reply, realising it has typed it in the topic field, then having to close the onscreen key board and scroll up to see what the correct topic was and should again be, then deleting the reply I've started typing from the topic field, then typing the original correct topic again, searching and selecting in the list, then scrolling to the actual message field, then trying to remember the reply I started typing when it was wrongly entered in the topic field. Very frustrating and time wasting. Repeats about 5x daily, 6 days per week.

Desired behaviour:
When using quote and reply: use the same topic as the quoted message by default, and start with the cursor in the message field below the quoted text.

Thanks!

@alya
Copy link
Collaborator

alya commented Apr 25, 2023

Thanks you for the report! I expect that we'll fix this in the flutter version of the app (https://github.com/zulip/zulip-flutter).

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 25, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 25, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 25, 2023
@chrisbobbe
Copy link
Contributor

chrisbobbe commented Apr 25, 2023

Thanks for the report! I think this won't be too difficult to fix in the RN app actually.

I think I know what's going on:

When you want to compose a new message from an interleaved stream narrow, the app isn't good at choosing a reasonable value for the topic input; in fact, it doesn't choose any value. Instead, it has a (kind of awkward) mechanism to nudge the user to specify a topic: when the user taps the message input and the topic input is empty, we auto-focus the topic input. I guess that mechanism accomplishes its purpose, but it sure is annoying when it seems like the app could choose a reasonable topic for you.

I think that's what's going on here: when you do a quote-and-reply and the topic input is empty, probably you want the topic of the selected message, and the app should use that. PR coming soon. 🙂

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 27, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 27, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Apr 27, 2023
Note that we have logic in `handleMessageFocus` to respond to focus
on the message input by auto-focusing the *topic* input in some
cases. That would be annoying if it happened here: you do a
quote-and-reply, and suddenly the topic input is focused?(!)

But that topic auto-focusing should be defeated in all cases where
it was active. In particular, since the previous commit, the topic
input won't be empty; the logic in `handleMessageFocus` will see
that and skip the auto-focus.

Fixes: zulip#5718
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 13, 2023
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants