Fix multiple back buttons are required to navigate back. #2135
Conversation
So that it can override the hardware back button press implementation present in the TabNavigation of main tabs. Fix: two hardware back button press are required to navigate back.
So that main tabs state can be considered in stream tabs on hardware back button press.
So that hardware back button press can be handled in that.
Fix multiple back button press are required to navigate back if all streams tab is selected in the stream tab of main tabs.
So that main tabs are not re-rendered when canGoBack changes.
Complete fix for multiple back button are required to navigate back. Fix: zulip#2098
So that route can be popped out on back button from stack.
If current route is lighbox then also we can go back. Created new selector isCurrentRouteIsLightbox, which can be used to distinguish such cases and back arrow button can be rendered accordingly. Fix: zulip#2127.
Fix: multiple back button press are required if narrowed from tab other home i.e steams and conversation. Because one press was captured by main tab to navigate to home tab that is the first tab. Fix: zulip#2098
|
Heads up @jainkuniya, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
It looks like a couple of the steps in this PR are to add more layers between our different navigators -- specifically between the outer In chat last week, after some very helpful comments from @HarshulSharma000 my conclusion was that we want to go the opposite direction: our inner navigators should be direct children (in Do you disagree? Can you explain why? Perhaps that chat thread is the right place for further discussion. |
|
This was fixed in a simpler way. |
#2098