Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

people auto complete: Send user ID for users having same full name. #4094

Merged
merged 1 commit into from
Jul 2, 2020

Commits on Jul 2, 2020

  1. people auto complete: Also send user ID for users having same full name.

    Previously, our @-mention autocomplete had a bug, wherein it
    failed to correctly mention the specific user if more than one
    users had the same full name.
    
    Now, if more than one users have the same full name, we send the
    user ID as well to ensure that the correct user is @-mentioned.
    
    The user ID is not sent for every @-mention to ensure the
    behaviour is consistent with the web app, i.e., we send it
    only in case of ambiguity.
    
    See the `get_mention_syntax` function in `static/js/people.js`
    in the webapp source for the origin of this syntax.
    agrawal-d authored and chrisbobbe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ebcaae2 View commit details
    Browse the repository at this point in the history