Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI tweaks on mention-unsubscribed warning #4219

Merged
merged 3 commits into from
Aug 11, 2020
Merged

UI tweaks on mention-unsubscribed warning #4219

merged 3 commits into from
Aug 11, 2020

Commits on Aug 11, 2020

  1. compose: Adjust size and shape of button on mention-unsubscribed warn… 

    …ing.

As it was, the button had conspicuously tall vertical padding, and
very little horizontal padding.
    @gnprice
    gnprice committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f7e6e74 View commit details
    Browse the repository at this point in the history

  2. compose: Cut border on mention-unsubscribed warning. 

    This border feels pretty heavy, and unbalanced because there isn't
a similar border at the bottom.

The distinct background color makes a nice sharp contrast against
the message list all by itself.

When there are several of these banners, this means there won't be a
dividing line between them.  I tried that out and it looked fine.
    @gnprice
    gnprice committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    6cf3114 View commit details
    Browse the repository at this point in the history

  3. compose: Cut animation on mention-unsubscribed warning. 

    This animation looks kind of odd, and inappropriate for the entrance
of a banner.  See description here:
  zulip#4101 (comment)

Ideally we'd have an appropriate animation, like the banner sliding
in from the bottom.  But no animation at all actually looks pretty OK
to me here, and definitely better than this odd animation.

(We use the same odd animation for the "N unreads" banner, and it's
equally inappropriate there.  Likely we should just drop it there, too.)
    @gnprice
    gnprice committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7a23ac7 View commit details
    Browse the repository at this point in the history