deps: Upgrade to Node v12, in setup docs and in CI. #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to merge this as soon as the Travis build succeeds: One of the changes here is specifically to our Travis config, so the only reliable way to test that is to actually push it. (It's rare that we make changes to that file.) |
|
Great, thanks! |
We've been using this for local development for a little while, and all seems well. The major visible benefit to this upgrade is that startup times are much improved: zulip#3780 (comment) which means everything we do from a script becomes much faster. Fixes: zulip#3780
gnprice
force-pushed
the
pr-node-v12
branch
from
659035c
to
f83ccc6
Compare
|
CI passed; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using this for local development for a little while,
and all seems well.
The major visible benefit to this upgrade is that startup times are
much improved:
#3780 (comment)
which means everything we do from a script becomes much faster.
Fixes: #3780