import: Work around broken imports of '.'. #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug somewhere in our stack -- presumably Metro or one of its dependencies -- means that in src/notification/notificationActions.js the import from `.` was getting resolved not to the module built from its neighboring `index.js` file, as it should… but to the module corresponding to the directory `src/common/`. That also happens to be the directory where our only other imports from `.` are found. Seems like the bug may involve the resolution of `.` being inappropriately shared globally. In any case, the bug goes away when we make the import reference a little less special-looking, as `./`. Thread: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Notification.20Crash/near/1215247 Fixes: zulip#4818
gnprice
added
severe: crash
|
LGTM, thanks! Merged. |
This was referenced Jun 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug somewhere in our stack -- presumably Metro or one of its
dependencies -- means that in src/notification/notificationActions.js
the import from
.was getting resolved not to the module built fromits neighboring
index.jsfile, as it should… but to the modulecorresponding to the directory
src/common/.That also happens to be the directory where our only other imports
from
.are found. Seems like the bug may involve the resolutionof
.being inappropriately shared globally.In any case, the bug goes away when we make the import reference a
little less special-looking, as
./.Thread: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Notification.20Crash/near/1215247
Fixes: #4818