Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Run yarn upgrade. #5335

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

chrisbobbe
Copy link
Contributor

With a more specific upgrade pulled out into a commit just before, since we have a specific intention there.

@chrisbobbe chrisbobbe added P1 high-priority dependencies Pull requests that update a dependency file labels Apr 13, 2022
@chrisbobbe chrisbobbe requested a review from gnprice April 13, 2022 01:20
@chrisbobbe
Copy link
Contributor Author

I kicked the tires on iOS and Android, and didn't notice anything off.

@chrisbobbe chrisbobbe force-pushed the pr-bump-sentry-react-native branch from 964ca76 to 4c61262 Compare April 18, 2022 22:00
@chrisbobbe
Copy link
Contributor Author

chrisbobbe commented Apr 18, 2022

Rebased past #5230, the RN v0.65 upgrade, and kicked the tires again (iOS and Android).

@chrisbobbe
Copy link
Contributor Author

Don't forget GitHub's handy "rich diff" feature when viewing yarn.lock changes:

image

The `resolutions` line can go away when react-native itself starts
pinning to use-subscription <1.6.0. It does that in
facebook/react-native@553463489, which hasn't yet been released; see
there for more details.
@gnprice gnprice force-pushed the pr-bump-sentry-react-native branch from 4c61262 to 52b6d79 Compare April 18, 2022 23:37
@gnprice
Copy link
Member

gnprice commented Apr 18, 2022

Thanks! Looks good; merging.

@gnprice gnprice merged commit 52b6d79 into zulip:main Apr 18, 2022
@chrisbobbe chrisbobbe deleted the pr-bump-sentry-react-native branch April 18, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file P1 high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants