deps: Upgrade to RN v0.65! #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the RN commits that touch the RN template app that are in v0.64.2 but are not in v0.65.2. They're ordered from first to last (oldest to newest). I.e., they're the commits in the output of Along with whether, how, and when we propagate the changes to our app. We shouldn't forget to update this, if necessary, to follow any changes made during code review and merge.
|
gnprice
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Thanks @chrisbobbe for all your detailed work on this! Including that table of upstream commits, and the series of prep PRs that got our libdefs up to snuff.
Just one small comment below, and a followup opportunity I noticed that's actually about a previous upgrade. Otherwise all looks good!
| @@ -61,20 +61,6 @@ flow-typed/expo-screen-orientation_vx.x.x.js | |||
| ; counterparts in node_modules/react-native: | |||
| flow-typed/jest_v26.x.x.js | |||
|
|
|||
| [declarations] | |||
| ; We should be able to remove this once we're on RN v0.65, which has | |||
There was a problem hiding this comment.
Cool.
This prompted me to go grepping for other such opportunities. I found one in docs/howto/profiling.md, for a previous upgrade to RN v0.63:
You can add `Date.now()` to measure times (or better,
`performance.now()` once we're on RN v0.63+; see our #4245), and
`console.log()` to print the results.
package.json
Outdated
| "react-intl": "5.24.6", | ||
| "react-native": "0.64.3", | ||
| "react-native": "0.65.2", | ||
| "react-native-codegen": "^0.0.7", |
There was a problem hiding this comment.
It looks like in the template app, react-native-codegen goes in devDependencies. Can we similarly put it there?
|
Thanks for the review! Revision pushed. |
Note: If you get an error like CocoaPods could not find compatible versions for pod "RCT-Folly" on `yarn` or `pod install` when crossing this commit (checking out a branch that has it from one that doesn't, or vice versa), run `pod update RCT-Folly` from `ios/` and try the command again. Background: facebook/react-native#32659 (comment) In this commit: - Bump `react` and `react-test-renderer` to follow the RN template app - Adapt to changes in Flow: - Two options removed: esproposal.optional_chaining esproposal.nullish_coalescing - RN no longer clobbers Flow's built-in definitions for `fetch`! - Etc.; see comments - Add react-native-codegen, at ^0.0.7. The RN maintainers moved this dep back and forth between the `react-native` NPM package and the RN template app. For RN v0.65 it ended up in the template app, suggesting that projects using RN v0.65 should depend on it directly. So, do that. See discussion: zulip#5324 (comment)
This is now appropriate, following RN v0.65, where React Native stopped clobbering the Response type with `any`.
|
Thanks! Looks good; merging. I've added a small docs commit on that profiling update, and also tweaked the last commit's summary-line prefix to be a bit more general (moving "checkCompatibility" into the rest of the summary line, and saying "api" instead which is broad enough to be something that recurs.) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5230