deps: Upgrade to RN v0.67! #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the RN commits that touch the RN template app that are in v0.66.4 but are not in v0.67.4. They're ordered from first to last (oldest to newest). I.e., they're the commits in the output of Along with whether, how, and when we propagate the changes to our app. We shouldn't forget to update this, if necessary, to follow any changes made during code review and merge. NOTE: This time, we'd like to postpone the Gradle upgrade that appears in the template-app changes. Before taking that upgrade, we need to take expo/expo@97ff91217 in our
|
😄
Because they don't have Git set up properly to keep them consistent. Specifically, they don't appear to have a (Hmm, that comment isn't quite right -- it's describing the line right after it, but then the next line says that Looks like here's where I added those two lines, back in 2018: 58c70ec Maybe I should attempt to get that fixed in react-native upstream. … Oh, I see. They actually had that, and ripped it out in facebook/react-native@fc553ed8e . ¯_(ツ)_/¯ Not worth trying to push on, then -- there are bigger things to fix. It seems like at least part of the churn came from enabling that configuration, and then disabling it again. |
Sure are a lot of these! That is strengthening my feeling that we don't want those files. Sometimes the numbers even go backward, as in facebook/react-native@73afb97e8 / v0.67.0-rc.5 . Which is a nice illustration of how this setup doesn't entirely succeed at its goal of getting all the versions under control. |
Done to follow the template-app change in facebook/react-native@b4ac21152, on the path to the RN v0.67 upgrade. The app built and ran fine with `tools/run-android` after this, in my testing just now.
Done to follow the template-app change in facebook/react-native@046b02628, on the path to the RN v0.67 upgrade, with the fixup in facebook/react-native@2f8e52b52. The fixup is aimed at projects that use RN's nightly builds. We don't, but we might as well follow the template app. And using nightly releases is mentioned in a (possibly early/outdated?) draft for opting into RN's "new architecture": https://reactnative.dev/docs/next/new-architecture-app-intro#use-a-react-native-nightly-release and I suppose one day we'll want to be using that new architecture.
Done to follow the template-app change in facebook/react-native@1ad45f516, on the path to the RN v0.67 upgrade.
In this commit: - Bump `react-native` and `flow-bin` versions; point Flow config to new Flow version - Suppress an error from the new Flow version - rm -rf node_modules && rm -rf ios/Pods && yarn The project.pbxproj changes seem to have happened with the `pod install` that got run as part of our Yarn postinstall script.
|
Thanks @chrisbobbe for taking care of this upgrade! This all looks good to me. Merging. |
gnprice
added a commit
that referenced
this pull request
Jun 25, 2022
The comment was accurate about the first line but not the second. For some history in RN upstream for comparison, see: #5426 (comment)
|
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Sep 26, 2022
Done to follow the template-app change in facebook/react-native@13107fa3d. (Which it looks like RN actually intended to make in facebook/react-native@85249cafe but forgot; that's not important, I think.) We didn't take facebook/react-native@13107fa3d on the path to the RN v0.67 upgrade because of a blocker that was resolved with the Expo 44 upgrade in expo/expo@3edc37ae4. For details, expand the `expo-screen-orientation` block in zulip#5203 (comment) and see the comment on the `Installing ExpoModulesCore 0.6.4` output from `pod install`. Done by following the "How to upgrade Gradle" instructions at the top of gradle-wrapper.properties. The result matched the template-app commit except for upstream's line endings got messed with because they didn't have Git set up properly to keep them consistent: zulip#5426 (comment) .
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Nov 22, 2022
Done to follow the template-app change in facebook/react-native@13107fa3d. (Which it looks like RN actually intended to make in facebook/react-native@85249cafe but forgot; that's not important, I think.) We didn't take facebook/react-native@13107fa3d on the path to the RN v0.67 upgrade because of a blocker that was resolved with the Expo 44 upgrade in expo/expo@3edc37ae4. For details, expand the `expo-screen-orientation` block in zulip#5203 (comment) and see the comment on the `Installing ExpoModulesCore 0.6.4` output from `pod install`. Done by following the "How to upgrade Gradle" instructions at the top of gradle-wrapper.properties. The result matched the template-app commit except for upstream's line endings got messed with because they didn't have Git set up properly to keep them consistent: zulip#5426 (comment) .
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Nov 23, 2022
Done to follow the template-app change in facebook/react-native@13107fa3d. (Which it looks like RN actually intended to make in facebook/react-native@85249cafe but forgot; that's not important, I think.) We didn't take facebook/react-native@13107fa3d on the path to the RN v0.67 upgrade because of a blocker that was resolved with the Expo 44 upgrade in expo/expo@3edc37ae4. For details, expand the `expo-screen-orientation` block in zulip#5203 (comment) and see the comment on the `Installing ExpoModulesCore 0.6.4` output from `pod install`. Done by following the "How to upgrade Gradle" instructions at the top of gradle-wrapper.properties. The result matched the template-app commit except for upstream's line endings got messed with because they didn't have Git set up properly to keep them consistent: zulip#5426 (comment) .
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5232