dep types: Use TsFlower for expo-web-browser (and expo-modules-core) #5449
Conversation
chrisbobbe
force-pushed
the
pr-tsflower-expo-web-browser
branch
from
a361e92
to
3e87323
Compare
|
Just rebased, resolving some conflicts. (Kinda tricky this time! 🙂) |
As I've used TsFlower for more expo-* libraries, I've regularly had to suppress unresolved-import errors on imports from expo-modules-core. I'd expect to have to keep doing that, as long as we don't have Flow types for expo-modules-core. So, add some, using TsFlower, and adjust the patches so those now-unneeded suppressions never get added.
gnprice
force-pushed
the
pr-tsflower-expo-web-browser
branch
from
3e87323
to
27c6742
Compare
There was a problem hiding this comment.
Thanks @chrisbobbe! This looks good, modulo one comment below.
... Ha, and then I forgot that one comment and went ahead and merged, oops. Nothing critical, but would be a nice followup.
| +/* $FlowFixMe[cannot-resolve-module]: expo-modules-core should (peer-)depend | ||
| + on react-native-web if it wants this to be a meaningful type. */ |
There was a problem hiding this comment.
Hmm, or perhaps better: we could delete this file entirely, say in tools/tsflower after running TsFlower (in run_only.)
In general we don't ever care about a .web.js.flow file, because it isn't applicable when not on web. In a future where TsFlower has a feature to tell it to skip some files, as suggested here:
# TODO: Send r-n-tab-view a .npmignore patch to stop shipping this directory.
# Also perhaps give TsFlower a way to tell it things to skip.
rm -rf "${rootdir}"/types/"${package}"/lib/typescript/example/
we'd have entries there like *.web.d.ts.
There was a problem hiding this comment.
Good idea! #5478
As suggested by Greg at zulip#5449 (comment)
|
Thanks for the review! Just sent #5478 for that followup. |
expo-web-browserbecause I remembered it's one of the deps we'd like to upgrade in #5441, andexpo-modules-coreso that it's available totypes/expo-*.