MainTabsScreen: Add Users icon to bottom nav #5506
Conversation
|
WIP Not ready for review yet, feedback or suggestions are welcome anytime :D |
manila
force-pushed
the
manila-issue-5495-pr
branch
3 times, most recently
from
31b821e to
2db36ec
Compare
manila
force-pushed
the
manila-issue-5495-pr
branch
from
2db36ec to
83313ce
Compare
| export default function UsersInfoScreen(props: Props): Node { | ||
| return ( | ||
| <SafeAreaView mode="padding" edges={['top']} style={{ flex: 1 }} scrollEnabled={false}> | ||
| <UsersProfileCard filter="" /> | ||
| </SafeAreaView> | ||
| ); |
There was a problem hiding this comment.
Instead of having a trivial wrapper component like this, let's have just one component that does the job of both this and the inner component.
(I see the existing UsersScreen looks this way too. Maybe I'll go and fix that now.)
There was a problem hiding this comment.
(I see the existing
UsersScreenlooks this way too. Maybe I'll go and fix that now.)
| import UsersProfileCard from './UsersProfileCard'; | ||
|
|
||
| type Props = $ReadOnly<{| | ||
| navigation: AppNavigationProp<'users'>, |
There was a problem hiding this comment.
This should follow the model of the other screen components that have the same navigation-related context -- which means the ones that also appear in MainTabsScreen in the same way that you're adding this one there. Take a look at the navigation props on those.
| navigation: AppNavigationProp<'users'>, | ||
| |}>; | ||
|
|
||
| export default function UsersInfoScreen(props: Props): Node { |
There was a problem hiding this comment.
nit: function name of default export should match filename
Fixes: #5495
This the start of a proposed fix for issue #5495
TODO: