android: Fix animated GIFs in lightbox, by getting Fresco version automatically #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
added
a-Android
upstream: RN
|
Huh, cool. LGTM, please merge at will! 🙂 |
…omatically This follows upstream's instructions: Note: the version listed above may not be updated in time. Please check `ReactAndroid/gradle.properties` in the main repo to see which fresco version is being used in a specific tagged version. https://reactnative.dev/docs/0.67/image#gif-and-webp-support-on-android except in an automated way. Happily this is even reasonably clean. Fixes: zulip#5607
gnprice
force-pushed
the
pr-android-anigifs
branch
from
1316bf6
to
b301e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows upstream's instructions:
https://reactnative.dev/docs/0.67/image#gif-and-webp-support-on-android
except in an automated way. Happily this is even reasonably clean.
Fixes: #5607