LegalScreen: Turn into a global, all-accounts screen #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user should be equally aware of the terms for all realms the app is interacting with, and that includes realms other than the active account's realm. (There would be even more interaction in a future with better multi-account support.) Rather than make the user traverse all realms with the "active account" pointer to find all the relevant terms, it seems nicer to show them together on this one page.
Since the realms' individual policy URLs are shown (really just to disambiguate different realms with the same name) it looks a bit odd if the "Zulip terms" line doesn't have a URL, so add it.
chrisbobbe
force-pushed
the
pr-global-legal
branch
from
e72df8b
to
a5123e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should be equally aware of the terms for all realms the app is interacting with, and that includes realms other than the active account's realm. (There would be even more interaction in a future with better multi-account support.)
Rather than make the user traverse all realms with the "active account" pointer to find all the relevant terms, it seems nicer to show them together on this one page.
Also, for #4729, if we still want the "Legal" link to live in a settings menu, then we'll want to choose whether the "Legal" screen is per-account or global, and it seems more global to me.
(The "After" screenshot shows an IP address as a realm. It's a valid realm—my dev server—but most people won't see ugly numbers like that.)