Handle @topic mentions #5779
Merged
Handle @topic mentions #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
a-message list
a-compose/send
gnprice
reviewed
Oct 11, 2023
Comment on lines
115
to
125
| // This assumes that we'll never want to show two suggestions for one query. | ||
| // That's OK, as long as all of WildcardMentionType's members are synonyms, | ||
| // and it's nice not to crowd the autocomplete with multiple items that mean | ||
| // the same thing. But we'll need to adapt if it turns out that all the | ||
| // members aren't synonyms. | ||
| const match = ( | ||
| isStreamOrTopicNarrow(destinationNarrow) ? kOrderedTypesWithStream : kOrderedTypesWithoutStream | ||
| ).find( | ||
| ): $ReadOnlyArray<WildcardMentionType> => | ||
| // Since not all of WildcardMentionType's members are synonyms -- "topic" | ||
| // has a different meaning than "all", "everyone", and "stream" -- show | ||
| // all matches instead of just the first. That's so e.g. a query for | ||
| // "topic" in the user's language can't be short-circuited by the "all" | ||
| // result. |
There was a problem hiding this comment.
Hmm, this means a little UX regression in that the results will now be crowded with several items that mean the same thing.
I think it won't be too complicated to maintain our existing nice behavior of suppressing dupes, while not inappropriately suppressing @topic. The main thing to do in the code is that in retrospect the existing version probably stretches too hard to make it table-driven, with those constants kOrderedTypes…, rather than writing out logic in code in the function. If we do the latter, it becomes pretty straightforward to add @topic without losing dupe suppression on the others.
I just wrote up a version of that; I'll push it to the PR branch.
|
Otherwise LGTM! Thanks for taking care of these. |
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Oct 18, 2023
…tion As Greg suggests: zulip#5779 (comment) > The main thing to do in the code is that in retrospect the > existing version probably stretches too hard to make it > table-driven, with those constants `kOrderedTypes…`, rather than > writing out logic in code in the function. If we do the latter, it > becomes pretty straightforward to add `@topic` without losing dupe > suppression on the others.
chrisbobbe
force-pushed
the
pr-mention-topics
branch
from
ee4541f
to
9a79879
Compare
|
Thanks for the review! Revision pushed, with that change. |
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-mention-topics
branch
from
9a79879
to
0f3cbae
Compare
…tion As Greg suggests: zulip#5779 (comment) > The main thing to do in the code is that in retrospect the > existing version probably stretches too hard to make it > table-driven, with those constants `kOrderedTypes…`, rather than > writing out logic in code in the function. If we do the latter, it > becomes pretty straightforward to add `@topic` without losing dupe > suppression on the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these two issues:
@topicto typeahead #5772Fixes: #5746
Fixes: #5772