Add follow/unfollow options to topic action sheet #5794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it possible that this test file has never actually been getting run by our test suite? Yikes. Now it does.
This patch is a backport of commit facebook/react-native@cf631ad59 from upstream. I've also pushed it to a branch in our fork: zulip/react-native@v0.68.7...0.68.7-zulip In particular this avoids a symptom which I otherwise see on Node v18.16.1: ``` FAIL src/webview/__tests__/generateInboundEventEditSequence-test.js ● Test suite failed to run TypeError: Cannot redefine property: performance at Object.<anonymous> (node_modules/react-native/jest/setup.js:20:20) ``` The symptom affects three of our test files: src/__tests__/test-test.js src/webview/__tests__/generateInboundEventEditSequence-test.js src/webview/js/__tests__/rewriteHtml-test.js because those are the three that have `@jest-environment` annotations calling for "jsdom" or related environments.
Done by rerunning tools/build-icon-font . Ideally this should have happened at the same time as upgrading `@zulip/shared`, so in commit 9716c9e and/or previous upgrades.
This SVG file is copied verbatim from the web app. Ideally we'd do that by upgrading `@zulip/shared`... but now that this codebase is legacy and we're spending less time maintaining it, we've accumulated a backlog of changes there that are incompatible and require adjustments in our code. So the expedient thing is to just take the individual icon we currently need and pull it into our tree directly. Moreover, we want this icon inside the webview. This makes only the second Zulip icon we've put inside the webview, after the "play_button" icon we added just the other day; and I wouldn't say we've developed a good streamlined pattern for it. But for this legacy codebase, we'll content ourselves with just following the pattern set by "play_button". That also means duplicating the icon's SVG file into two places. Awkward, but at least it's not any kind of space-consumption issue: the file is under a kilobyte in size.
This is most visible on the inbox screen, the app's home screen. It also appears on the screen that lists the topics for a stream.
As discussed back in 4851f34, the values get stringified either by `lodash.escape` or by the `join`. Stringifying a boolean works just as nicely as a number.
Together with the preceding few commits which add this icon in some other places in the UI, this completes zulip#5770. Fixes: zulip#5770
These are the current values on chat.zulip.org.
gnprice
added
webapp parity
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #5793.
Fixes: #5771