Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade react-native-simple-toast to 3.3.1, the latest #5858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisbobbe
Copy link
Contributor

@chrisbobbe chrisbobbe commented Apr 16, 2024

Unfortunately this causes a peer-dependency warning:

warning " > react-native-simple-toast@3.3.1" has incorrect peer
dependency "react-native@>=0.71.0".

but no issues are observed in manual testing of this library's functionality on iOS or Android.

While we're at it, use TsFlower for the types. The types tell us that Toast.show's duration parameter is required; so, include it, even though the implementation uses a fallback value (Toast.SHORT) if the argument isn't passed.

This lets us pull in the latest version of the "Toast" pod for iOS; that's version 4.1.1. That version has a "privacy manifest" --

scalessec/Toast@401141d79
scalessec/Toast@607b12954
scalessec/Toast@85b492dd8

-- which should hopefully help us with #5847. Granted, the Toast pod's privacy manifest file seems pretty boring; I think it just declares that the library doesn't access any sensitive data. Still, "Toast" is explicitly included in a list published by Apple of "commonly used SDKs" that require their own privacy manifest:
https://developer.apple.com/support/third-party-SDK-requirements/
(In fact, I think it's the only one of zulip-mobile's dependencies that appears in that list.)

Related: #5847

Unfortunately this causes a peer-dependency warning:

  warning " > react-native-simple-toast@3.3.1" has incorrect peer
    dependency "react-native@>=0.71.0".

but no issues are observed in manual testing of this library's
functionality on iOS or Android.

While we're at it, use TsFlower for the types. The types tell us
that `Toast.show`'s duration parameter is required; so, include it,
even though the implementation has logic to fall back to Toast.SHORT
if the argument isn't passed.

This lets us pull in the latest version of the "Toast" pod for iOS;
that's version 4.1.1. That version has a "privacy manifest" --

  scalessec/Toast@401141d79
  scalessec/Toast@607b12954
  scalessec/Toast@85b492dd8

-- which should hopefully help us with zulip#5847. Granted, the Toast
pod's privacy manifest file seems pretty boring; I think it just
declares that the library doesn't access any sensitive data. Still,
"Toast" is explicitly included in a list published by Apple of
"commonly used SDKs" that require their own privacy manifest:
  https://developer.apple.com/support/third-party-SDK-requirements/
(In fact, I think it's the only one of zulip-mobile's dependencies
that appears in that list.)

Related: zulip#5847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant