-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug is solved, I have added the icon.png file #5909
base: main
Are you sure you want to change the base?
Conversation
please, move it to https://github.com/zulip/zulip-mobile/tree/main/fastlane/metadata/android/en-US/images instead, as instructed :) |
thanks |
So now is this issue resolved?? This means my PR is ready to be merged? |
We can hope |
Thanks for the guidance.. by the way!! |
Hello @licaon-kter I would like to know that if someone could just review my pull request and merge it, if possible. |
Hi @kanishka-coder0809, welcome. Where did you obtain the image file used in this PR? For a version we'll merge, there'll need to be a clear explanation of how the image file was produced and how it relates to the many other versions of the Zulip logo we already have. The simplest solution is to just copy one of the existing files. Before we can merge a change it'll also need to meet our Git style guide. This change should be a single commit with an appropriate commit message. See that document for details on an appropriate commit message. |
Thank you for the feedback and the guidance regarding the PR. @gnprice The image file was initially downloaded from the web, but I reproduced it to ensure it aligns with the project's standards. After creating the image, I added it to the appropriate location in the repository following the structure provided after cloning the repo. I will make the necessary adjustments to meet the Git style guide, including consolidating the changes into a single commit with a proper commit message. Let me know if there are any additional steps or specific requirements for the image or the commit. |
I had actually already opened #5897 ^^ |
hello @licaon-kter and @gnprice It's been a while that my PR is not merged yet.. Please tell if I need to make any changes in it to be merged. I would be happy to hear you feedbacks. |
In the issue I have added the icon.png file in the images folder which is a sub folder in fastlane. Fix #5908