Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture is shifted on iPhone X in landscape orientation #200

Closed
johnnyoin opened this issue Oct 18, 2017 · 5 comments
Closed

Picture is shifted on iPhone X in landscape orientation #200

johnnyoin opened this issue Oct 18, 2017 · 5 comments

Comments

@johnnyoin
Copy link

When running the example project on iPhone X simulator, turn it to landscape and tap the picture to go fullscreen.

The fullscreen image is shifted to the left.

@ElectroBuddha
Copy link

I can confirm, the imageslide is not centered on first rotation to landscape in fullscreen (only on iPhone X). After dragging the scrollview, image becomes centered again.

@ghost
Copy link

ghost commented Nov 2, 2017

I have the same issue as @ElectroBuddha .

imageslide is not centered on first rotation to landscape in fullscreen (only on iPhone X). After dragging the scrollview, image becomes centered again.

@zvonicek
Copy link
Owner

Hi guys, I confirm the bug, however, I haven't figured out yet how to fix it. It seems the frame is shifted on iPhone X for some reason. Will be glad for any help / PR solving the issue.

@scottcc
Copy link

scottcc commented Jan 22, 2018

I'm suspecting it has to do with the "notch" - does it shift in both landscape orientations? I'd also look into whether constraints are using the newer "safe areas". Just my thoughts at the moment anyway.

@zvonicek
Copy link
Owner

I finally fixed the issue! It was enough to just set the contentInsetAdjustmentBehavior on scroll view to .never.

dirkoswanepoel pushed a commit to dirkoswanepoel/ImageSlideshow that referenced this issue Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants