Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button doesn't work #242

Closed
piercifani opened this issue Apr 17, 2018 · 1 comment
Closed

Close button doesn't work #242

piercifani opened this issue Apr 17, 2018 · 1 comment
Labels
bug

Comments

@piercifani
Copy link
Contributor

Seems that 1.5.2 broke the close button when the slideshow is presented fullscreen. Please see attached video for reproduction steps

untitled
@zvonicek
Copy link
Owner

Thanks for the report! I'm already aware of the bug and will fix it ASAP.

@zvonicek zvonicek added the bug label Apr 17, 2018
zvonicek added a commit that referenced this issue Apr 17, 2018
@zvonicek
Fix the full screen controller's close button (fixes #242)
cc90556
zvonicek referenced this issue Apr 17, 2018
@zvonicek
Fix interactive dismiss regression on iOS 11
a5c5cc6
zvonicek added a commit that referenced this issue Apr 17, 2018
@zvonicek
Fix the full screen controller's close button (fixes #242)
9f1bf92
zvonicek added a commit that referenced this issue May 27, 2018
@zvonicek
Page indicator customization (#251)
f374727 
* Implement draft of customizable page indicator

* Simplify PageIndicatorView page handling

* Add target action for page indicator

* Rework the page indicator positioning handling

* Improve example project

* Fix the full screen controller's close button (fixes #242)

* Fix retain cycle bewteen ImageSlideshow and ZoomAnimatedTransitioning

* Set swift_version to 4.0

* Set UIPageControl height to 30

* Fix underPadding behaviour

* Improve page indicator backward compatibility

* Split PageIndicator implementation to separate file

* Set BG slideshow colour in example project to white

* Improve safe area handing in page indicator

* Update example project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piercifani @zvonicek