LiveView rewrite #391
Merged
LiveView rewrite #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonimirr
added
frontend
release
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some consideration, I've decided to ditch React and use purely Elixir for Tenantee.
The reason for this is mostly that the previous code was messy and I wanted to refactor it anyway, but with LiveView, I don't have to worry about the UI not getting up-to-date as the UI is in the same codebase.
I will be porting the old codebase to the new one.
If you wish to help be my guest, but please let me know in advance so we don't end up working on the same thing at the same time.
This PR focuses solely on functionality and the tests will be added shortly in another PR.