Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix major mistake in the README. #7

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Fix major mistake in the README. #7

merged 1 commit into from
Aug 21, 2022

Conversation

ezio-melotti
Copy link
Contributor

Don't merge this just yet.
I want to see what happens when I delete my fork.

@ezio-melotti ezio-melotti closed this by deleting the head repository Aug 21, 2022
@ezio-melotti
Copy link
Contributor Author

ezio-melotti commented Aug 21, 2022

Looks like the PR got closed, but the changes are still available, and there is a "Reopen and comment" button too.

@zware can you reopen the PR and see what happens?

Are you able to push changes to the branch?

@zware
Copy link
Owner

zware commented Aug 21, 2022

Reopen appears to be an option.

@zware zware reopened this Aug 21, 2022
@zware
Copy link
Owner

zware commented Aug 21, 2022

I'm not sure if I can push to the branch, but I'm only on a phone yet this morning.

@@ -1,2 +1,2 @@
# test
Test repository. Not for testing.
Test repository. For testing.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Test repository. For testing.
Test repository. For not testing.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't appear to be able to commit this suggestion, so it may be that I can only merge it as is rather than being able to update. Will try from a real checkout.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't appear to have any way to push to this branch, though gh pr checkout was able to check it out.

@zware zware merged commit eedb107 into zware:main Aug 21, 2022
@zware
Copy link
Owner

zware commented Aug 21, 2022

Merging worked as expected, even though the fork is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants