Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch endPoint to endpoint #10

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Switch endPoint to endpoint #10

merged 2 commits into from
Jan 27, 2021

Conversation

hufftheweevil
Copy link
Contributor

Code still checks for endPoint as backup (for deprecation purposes)

@hufftheweevil
Copy link
Contributor Author

hufftheweevil commented Jan 26, 2021

And there I've gone and messed it up already... I'm not an amateur, but I'm definitely novice when working with PRs on different branches. I did that 2nd commit after doing this PR. So I don't understand why it was included in this PR. I wanted to create a separate PR for that one. Do I need to create a new local branch each time I want to submit a new PR?

@marcus-j-davies
Copy link
Member

Nope - you're golden.

Github adds any commits to the latest PR (providing its on the same branch, and providing the PR has not yet been accepted), Which I will do a bit later (its 3:41 AM here).

I actually prefer the way this works.

@hufftheweevil
Copy link
Contributor Author

Got it - thanks for the explanation. The other commit was just a suggestion, really. Otherwise it errors if no params are given, even for a class/operation that requires no params.

@marcus-j-davies
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants