Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): try fixing the change detection #1130

Merged
merged 4 commits into from
Nov 17, 2020
Merged

fix(ci): try fixing the change detection #1130

merged 4 commits into from
Nov 17, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Nov 17, 2020 •
edited
Loading

@robertsLando
Copy link
Member Author

@AlCalzone Could you try with this?

@AlCalzone AlCalzone changed the title fix(ci): git diff fix(ci): try fixing the change detection Nov 17, 2020
@AlCalzone
Copy link
Member

I've wanted to avoid hardcoding master, but I guess we can't avoid that when we want to support comments too.

@AlCalzone
Copy link
Member

test comment

@AlCalzone AlCalzone merged commit dcec4c2 into master Nov 17, 2020
@AlCalzone AlCalzone deleted the fix#indexUpdate branch November 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @AlCalzone